Skip to content

use pub run for create test and remove [INFO] logs #35839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonahwilliams merged 7 commits into from
Jul 10, 2019
Merged

use pub run for create test and remove [INFO] logs #35839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
79e8808
use pub run for create test
Jul 10, 2019
62b781d
remove logspam
Jul 10, 2019
fe2410a
list used tags
Jul 10, 2019
b060f85
Update dart_test.yaml
Jul 10, 2019
b6ce562
dont remove loading lines
Jul 10, 2019
aba41a2
Merge branch 'quite_down_br_tests' of github.com:jonahwilliams/flutte…
Jul 10, 2019
88cd37b
only run one test
Jul 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions dev/bots/run_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ Future<void> runCommand(String executable, List<String> arguments, {
bool skip = false,
bool expectFlaky = false,
Duration timeout = _kLongTimeout,
bool Function(String) removeLine,
}) async {
final String commandDescription = '${path.relative(executable, from: workingDirectory)} ${arguments.join(' ')}';
final String relativeWorkingDir = path.relative(workingDirectory);
Expand All @@ -103,13 +104,18 @@ Future<void> runCommand(String executable, List<String> arguments, {
);

Future<List<List<int>>> savedStdout, savedStderr;
final Stream<List<int>> stdoutSource = process.stdout
.transform<String>(const Utf8Decoder())
.transform(const LineSplitter())
.where((String line) => removeLine == null || !removeLine(line))
.transform(const Utf8Encoder());
if (printOutput) {
await Future.wait<void>(<Future<void>>[
stdout.addStream(process.stdout),
stdout.addStream(stdoutSource),
stderr.addStream(process.stderr),
]);
} else {
savedStdout = process.stdout.toList();
savedStdout = stdoutSource.toList();
savedStderr = process.stderr.toList();
}

Expand Down
8 changes: 6 additions & 2 deletions dev/bots/test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,8 @@ Future<void> _runToolTests() async {
File(path.join(flutterRoot, 'bin', 'cache', 'flutter_tools.snapshot')).deleteSync();
File(path.join(flutterRoot, 'bin', 'cache', 'flutter_tools.stamp')).deleteSync();
}
if (noUseBuildRunner) {
// reduce overhead of build_runner in the create case.
if (noUseBuildRunner || Platform.environment['SUBSHARD'] == 'create') {
Copy link
Contributor

@dnfield dnfield Jul 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the logic at https://github.com/flutter/flutter/pull/35839/files#diff-a9d73960c607f511d218217af489e4d5R587 and following for this

Copy link
Contributor Author

@jonahwilliams jonahwilliams Jul 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite sure what you mean

Copy link
Contributor

@dnfield dnfield Jul 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's logic in there to check the subshard and run the right subset of tests using tags. I don't think it matches the logic in the build runner variant of the method.

Copy link
Contributor Author

@jonahwilliams jonahwilliams Jul 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh duh, got it my bad

await _pubRunTest(
path.join(flutterRoot, 'packages', 'flutter_tools'),
tableData: bigqueryApi?.tabledata,
Expand Down Expand Up @@ -591,6 +592,9 @@ Future<void> _pubRunTest(
case 'tool':
args.addAll(<String>['--exclude-tags', 'integration']);
break;
case 'create':
args.addAll(<String>[path.join('test', 'commands', 'create_test.dart')]);
break;
}

if (useFlutterTestFormatter) {
Expand All @@ -606,7 +610,7 @@ Future<void> _pubRunTest(
await runCommand(
pub,
args,
workingDirectory:workingDirectory,
workingDirectory: workingDirectory,
);
}
}
Expand Down
5 changes: 5 additions & 0 deletions packages/flutter_tools/dart_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
tags:
"no_coverage":
"create":
"integration":