use sentence case in error message titles #35750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
approved these changes
Jul 8, 2019
Member
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
LGTM
Surprised that this doesn't require any changes to tests. Maybe we should have a test covering that this returns what we expect?
goderbauer
added
the
framework
Piinks
added
waiting for tree to go green
and removed
waiting for tree to go green
labels
chunhtai
requested changes
Jul 16, 2019
jacob314
reviewed
Jul 16, 2019
Codecov Report
@@ Coverage Diff @@
## master #35750 +/- ##
==========================================
- Coverage 55.25% 55.14% -0.12%
==========================================
Files 188 188
Lines 17426 17320 -106
==========================================
- Hits 9629 9551 -78
+ Misses 7797 7769 -28
Continue to review full report at Codecov.
|
Contributor
|
@devoncarew will you be able to add a test for this? |
Contributor
Author
Hey, yeah, planning to. |
Contributor
Author
|
PTAL: test added, waiting for the bots to cycle green |
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
* use sentence case in error message titles * add a test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
Exception Caught By $librarytoException caught by $library. For the stdio flutter error reporter, the error title gets uppercased -EXCEPTION CAUGHT BY RENDERING LIBRARY. For the service protocol based flutter error reporter, the case is not manipulated, and as is doesn't agree with the library name -Exception Caught By rendering library.