Delay win-by-default in gesture arena #3552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Not really ready for review. Definitely needs test. |
abarth
force-pushed
the
delay_win_by_default
branch
2 times, most recently
from
3cb4fa4 to
8b93b09
Compare
Contributor
Author
|
@Hixie Ready for review now. |
Contributor
There was a problem hiding this comment.
add a comment saying why it might be null (presumably because it's not in the list, maybe because it's been cancelled already?)
Contributor
|
LGTM |
Wait until the end of the microtask to tell gesture recognizers that they've won in the gesture arena. This lets recognizers dispose reject themselves at arbitrary times without triggering gestures in awkward call stacks. Fixes flutter#3183
abarth
force-pushed
the
delay_win_by_default
branch
from
8b93b09 to
b39065b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait until the end of the microtask to tell gesture recognizers that
they've won in the gesture arena. This lets recognizers dispose reject
themselves at arbitrary times without triggering gestures in awkward
call stacks.
Fixes #3183