Skip to content

Remove print #35408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
goderbauer merged 1 commit into from
Jul 1, 2019
Merged

Remove print #35408

goderbauer merged 1 commit into from
Jul 1, 2019

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Jul 1, 2019

Description

Removes a print I accidentally submitted in #34012.

Related Issues

None

Tests

None

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@goderbauer goderbauer mentioned this pull request Jul 1, 2019
Merged
8 tasks
@goderbauer goderbauer requested review from Hixie and Piinks July 1, 2019 16:51
Piinks
Piinks approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

print('LGTM!');

@goderbauer goderbauer merged commit f357f8d into flutter:master Jul 1, 2019
@goderbauer goderbauer deleted the removerprint branch July 1, 2019 17:09
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@goderbauer @johnsonmh
Remove print (flutter#35408)
2868218
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Piinks Piinks Piinks approved these changes

@Hixie Hixie Awaiting requested review from Hixie

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@goderbauer @Piinks @googlebot