more ui-as-code #35393
Merged
more ui-as-code #35393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
added
the
c: contributor-productivity
dnfield
reviewed
Jul 1, 2019
dev/bots/prepare_package.dart
Outdated
| // Use our preferred MIME type for the files we care about | ||
| // and let gsutil figure it out for anything else. | ||
| if (mimeType != null) ...<String>['-h', 'Content-Type:$mimeType'], | ||
| ...<String>['cp', src, dest], |
Contributor
There was a problem hiding this comment.
nit: maybe this could just be a regular list of strings?
'cp',
src,
dest,
Contributor
Author
There was a problem hiding this comment.
Done.
I kept the same semantic as the original code. Technically I guess compiler could optimized it to be the same as what you propose.
dnfield
reviewed
Jul 1, 2019
dnfield
reviewed
Jul 1, 2019
dev/snippets/lib/snippets.dart
Outdated
| htmlEscape.convert(injections.firstWhere((_ComponentTuple tuple) => tuple.name == 'app').mergedContent), | ||
| } | ||
| : <String, String>{'serial': '', 'id': '', 'app': ''}); | ||
| if (type == SnippetType.application) |
Contributor
There was a problem hiding this comment.
Nit - this isn't really any worse than the previous construction, but still looks awkward to me. I wonder if it would read better to just initialize these to their empty values, and below do an if (type == SnippetType.application) { // update the values }
tango5614
added a commit
to tango5614/flutter
that referenced
this pull request
Jul 4, 2019
* commit 'a0c47e2216a2b50b70c478001cf5652f31a783af': (187 commits) Do not use ideographic baseline for RenderPargraph baseline (flutter#35493) Add type to StreamChannel in generated test code. (flutter#35367) Fix RenderFittedBox when child.size.isEmpty (flutter#35487) add APK build time benchmarks (flutter#35481) fix Selection handles position is off (flutter#34665) Move usage flutter create tests into memory filesystem. (flutter#35160) Include tags in SemanticsNode debug properties (flutter#35491) Re-apply 'Add currentSystemFrameTimeStamp to SchedulerBinding' (flutter#35492) CupertinoTextField vertical alignment (flutter#34723) Mark update-packages as non-experimental (flutter#35467) fix default artifacts to exclude ios and android (flutter#35303) Roll engine ffba2f6..7d3e722 (59 commits) (flutter#35489) Update macrobenchmarks README and app name (flutter#35477) mark windows and macos chrome dev mode as flaky (flutter#35495) Use the new service protocol message names (flutter#35482) Manual roll of engine 45b66b7...ffba2f6 (flutter#35464) more ui-as-code (flutter#35393) update reassemble doc (flutter#35164) New parameter for RawGestureDetector to customize semantics mapping (flutter#33936) Add --target support for Windows and Linux (flutter#34660) ...
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
* more ui-as-code * address review comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More usage of ui-as-code.
Related Issues
None
Tests
None
Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?