Add test case for Flutter Issue #27677 as a benchmark. #34870
Conversation
Piinks
added
engine
There was a problem hiding this comment.
backdrop_filter.dart:20:60 • prefer_const_constructors
You can open the "Dart Analysis" tool in IntelliJ to discover these kind of warnings locally.
There was a problem hiding this comment.
Odd, the window shows a green check mark for me. I actually had a couple of those warnings and fixed them, but they don't show now.
liyuqian
left a comment
liyuqian
left a comment
There was a problem hiding this comment.
Thanks for the test! Can you please also add your local test result (with blur, without blur, with group blur) in the PR description (and make sure to include them as the commit message during merge)? It would give us a good sense of how much speedup the damage rect could give us in this case.
There was a problem hiding this comment.
Can we add some background that could tell the difference between with and without a BackdropFilter? For example, put 10000 '0's in the stack below the BackdropFilter as https://api.flutter.dev/flutter/widgets/BackdropFilter-class.html did.
Otherwise looks good.
There was a problem hiding this comment.
I added the background text (in yellow) and rand some numbers on my Moto E2 and did another commit.
See #27677 I got the following results running the test on a Moto E2 which will help us determine how much we can gain by analyzing the operations and eliminating unnecessary repaints based on dirty rectangles/regions. no blurs - avg 216.0 fps over 3 samples blur the group - avg 22.9 fps over 3 samples blur each txt - avg 3.4 fps over 3 samples
|
Oh, BTW, you need to modify the manifest.yml to add this test to our dashboard. We can go over how to do this on Monday. |
|
Can you please post the numbers you got on Moto E2 on the PR description for reference? Also, please feel encouraged to use |
|
We need to baseline these new benchmarks now that they're live. |
|
Done. |
…r#34870) * Add test case for Flutter Issue flutter#27677 as a benchmark. See flutter#27677 I got the following results running the test on a Moto E2 which will help us determine how much we can gain by analyzing the operations and eliminating unnecessary repaints based on dirty rectangles/regions. no blurs - avg 216.0 fps over 3 samples blur the group - avg 22.9 fps over 3 samples blur each txt - avg 3.4 fps over 3 samples * Added the new benchmark to be tracked on the dashboard.
5 participants
See #27677
I got the following results running the test on a Moto E2 which
will help us determine how much we can gain by analyzing the
operations and eliminating unnecessary repaints based on
dirty rectangles/regions.