Fix Vertical Alignment Regression #34859
Conversation
justinmc
added
a: text input
| // | ||
| // That means that if the padding is uneven, center is not the exact | ||
| // midpoint of top and bottom. To account for this, the points are | ||
| // interpolated between independently. |
There was a problem hiding this comment.
the above center and below center alignments are interpolated independently
There was a problem hiding this comment.
Thanks, I was struggling to not say "we" or "I" in this sentence haha.
| } | ||
|
|
||
| // Interpolate between three stops using textAlignVertical. This is used to | ||
| // calculate the outline baseline, which ignores padding for its middle but |
There was a problem hiding this comment.
ignores padding when the alignment is middle and interpolates between the centered text box's top and the top of the content padding when the alignment is less than zero [etc...]
| if (textAlignVertical.y <= 0) { | ||
| // It's possible for begin, middle, and end to not be in order because of | ||
| // excessive padding. Those cases are handled by using middle. | ||
| if (begin >= middle) { |
|
@justinmc I'm not really sure how, but is it possible that this change caused webview_flutter to no longer vertically center web content correctly? This seems to have started with 1.7.6 and is fine in 1.7.5. Simple example with a webview going to a page with vertical centering. 1.7.5 shows correctly and 1.7.6 pushes everything to the top. |
|
Weird, I wouldn't think so... @collinjackson is it possible there is any connection between InputDecorator alignment and webview_flutter? |
Change the way outlined inputs vertically align their text to be more similar to how it used to be before a refactor. Fixes an edge case uncovered by a SCUBA test.
4 participants
This fixes a regression found while doing the roll where inputs with OutlineInputBorder and symmetrical padding don't center. This was caused by #34355.
The solution here is to treat OutlineInputBorder differently (as it was before the referenced PR) so that it ignores padding when centering, but considers padding when aligning elsewhere.