Skip to content

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Jun 18, 2019

Description

In order to merge in engine breaking change https://github.com/flutter/engine/pull/9281/files, this pr fixes the breaking test, just need to update engine version once engine pr is merged.

Related Issues

#5422

Tests

updated existing test

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@chunhtai chunhtai requested a review from goderbauer June 18, 2019 23:20
@chunhtai chunhtai added the framework flutter/packages/flutter repository. See also f: labels. label Jun 18, 2019
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai force-pushed the issue/5422-semantics branch 3 times, most recently from 33e7db3 to 1abb9ee Compare June 19, 2019 18:22
@chunhtai chunhtai force-pushed the issue/5422-semantics branch from 1abb9ee to db0e3f5 Compare June 19, 2019 19:54
@chunhtai
Copy link
Contributor Author

build should green, ui take some time to update

@chunhtai chunhtai merged commit c8c20fb into flutter:master Jun 19, 2019
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants