Skip to content

Conversation

@blasten
Copy link

@blasten blasten commented Jun 17, 2019

Description

The issue was that the script was configuring the dependency on libapp.so without taking the flavor into consideration. There should only be one libapp.so per ABI, but when there are multiple flavor, the num of variants is: num build types * num flavors.

Related Issues

Fixes: #31922 (comment), #34598

  • What went wrong:
    Execution failed for task ':app:transformNativeLibsWithMergeJniLibsForProductionRelease'.
    More than one file was found with OS independent path 'lib/armeabi-v7a/libapp.so'

Tests

I added the following tests:

  • App bundle content using flavors without explicit target platform

Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

Copy link
Contributor

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blasten blasten merged commit 358b9bd into flutter:master Jun 17, 2019
@blasten blasten deleted the gradle_flavors branch June 17, 2019 22:05
@jonahwilliams
Copy link
Contributor

Landed on red to unblock google3 roll

blasten pushed a commit that referenced this pull request Jun 18, 2019
@blasten blasten restored the gradle_flavors branch June 18, 2019 17:59
blasten pushed a commit that referenced this pull request Jun 18, 2019
blasten pushed a commit to blasten/flutter that referenced this pull request Jun 19, 2019
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

t: gradle "flutter build" and "flutter run" on Android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support app bundles with 32-bit and 64-bit binaries within them

4 participants