Skip to content

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Jun 15, 2019

Reverts #34514 - the bots weren't failing due to this.

Will land on red to rekick bots that should now be in order.

@dnfield dnfield requested a review from jmagman June 15, 2019 06:35
@dnfield dnfield requested a review from devoncarew June 15, 2019 06:35
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un-revert, auto-LGTM

@dnfield dnfield merged commit 3d58400 into master Jun 15, 2019
@dnfield dnfield deleted the revert-34514-revert-34365-flutter_frame_events branch June 15, 2019 07:01
@devoncarew
Copy link
Contributor

Just seeing this now -thanks for re-landing.

tango5614 added a commit to tango5614/flutter that referenced this pull request Jun 17, 2019
* master:
  retry on HttpException (flutter#34526)
  308c113 Roll src/third_party/skia 057a32d9a2c8..5fe7429babe2 (1 commits) (flutter/engine#9342) (flutter#34583)
  Add back ability to override the local engine in Gradle (flutter#34460)
  Added customizable padding for the segmented controll (flutter#34555)
  466a1d8 Roll src/third_party/skia 3721688f64a5..057a32d9a2c8 (1 commits) (flutter/engine#9340) (flutter#34558)
  Handles parsing APK manifests with additional namespaces or attributes (flutter#34535)
  add route information to Flutter.Navigation events (flutter#34508)
  Separate web and io implementations of network image (flutter#34112)
  pass .packages path to snapshot invocation (flutter#34517)
  [Material] Fix TextDirection and selected thumb for RangeSliderThumbShape and RangeSliderValueIndicatorShape (flutter#34501)
  redux of a change to use new engine APIs for Flutter.Frame events (flutter#34521)
  Roll engine b0757e6..f44b7b5 (4 commits) (flutter#34533)
  Roll engine 2589785..b0757e6 (6 commits) (flutter#34522)
  Revert "Revert "redux of a change to use new engine APIs for Flutter.Frame events (flutter#34365)" (flutter#34514)" (flutter#34530)
  Make sure fab semantics end up on top (flutter#34512)
  Revert "redux of a change to use new engine APIs for Flutter.Frame events (flutter#34365)" (flutter#34514)
  redux of a change to use new engine APIs for Flutter.Frame events (flutter#34365)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants