Skip to content

Conversation

@tvolkert
Copy link
Contributor

Description

This adds widget of the week video embeddings to the documentation blocks of the following widgets:

  • Spacer
  • MediaQuery
  • InheritedWidget

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

* Spacer
* MediaQuery
* InheritedWidget
@shihaohong shihaohong added the d: api docs Issues with https://api.flutter.dev/ label Jun 12, 2019
Copy link
Contributor

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvolkert
Copy link
Contributor Author

Landing on red because I need to kick the Win1 bot tests

@tvolkert tvolkert merged commit c40c687 into flutter:master Jun 12, 2019
@tvolkert tvolkert deleted the videos branch June 12, 2019 23:36
tango5614 added a commit to tango5614/flutter that referenced this pull request Jun 13, 2019
* master: (84 commits)
  Compatibility pass on flutter/material tests for JavaScript compilation. (9) (flutter#33378)
  fix Applying decoration for a table row widget will cause render exception (flutter#34285)
  Add widget of the week videos (flutter#34356)
  Roll engine ab5c14b..67aadb6 (2 commits) (flutter#34350)
  Re-apply compressionState changes. (flutter#34341)
  Revert "update the Flutter.Frame event to use new engine APIs (flutter#34243)" (flutter#34352)
  Change Xcode project developmentRegion to 'en' and plist CFBundleDevelopmentRegion to DEVELOPMENT_LANGUAGE (flutter#34293)
  update the Flutter.Frame event to use new engine APIs (flutter#34243)
  [flutter_tool] Don't truncate verbose logs from _flutter.listViews (flutter#34255)
  ab5c14b Set Dart version to git hash 3166bbf24b0c929eef33fd5d0f69e0f36a9009f3 (Dart 2.3.3-dev) (flutter/engine#9292) (flutter#34336)
  Prepare for Uint8List SDK breaking changes (flutter#34295)
  Roll engine b14d971..d3c213e (3 commits) (flutter#34331)
  Roll engine 4fc95eb..b14d971 (4 commits) (flutter#34310)
  4fc95eb Fixed memory leaks within FlutterFragment and FlutterView (flutter#34268, flutter#34269, flutter#34270). (flutter/engine#9288) (flutter#34305)
  Roll engine 2d2cfc0..de350c4 (2 commits) (flutter#34302)
  Roll engine 02e6a13..2d2cfc0 (3 commits) (flutter#34292)
  Split gradle_plugin_test.dart (flutter#34282)
  Roll engine 4d68474..02e6a13 (4 commits) (flutter#34281)
  Compatibility pass on flutter/widgets tests for JavaScript compilation. (8) (flutter#33377)
  Instrument usage of include_flutter.groovy and xcode_backend.sh (flutter#34189)
  ...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

d: api docs Issues with https://api.flutter.dev/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants