-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Preserving SafeArea : Part 2 #34298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Preserving SafeArea : Part 2 #34298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
reviewed
Jun 19, 2019
… check other potential spots.
dnfield
reviewed
Jun 25, 2019
dnfield
approved these changes
Jun 25, 2019
Contributor
dnfield
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo nit. Feel free to take it or leave it :)
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
* WIP * Added tests and updated SafeArea implementation. * Analyzer nits * Review feedback * Updated for SnackBar and PersistentFooterButton cases, added tests to check other potential spots. * doc addition for SafeArea * Typos
This was referenced Jun 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to flutter/engine#8848 and #33999
This PR addresses the issue of a layout incorrectly shifting as a result of the bottom
paddingbeing consumed by an obstruction (i.e. a software keyboard).This error presented in:
Scaffold
resizeToAvoidBottomInsets: false
BottomNavigationBar, SnackBar and PersistentFooter buttons affected.
An automatic flag has been added to the Scaffold class,
maintainBottomViewPadding, that will follow the viewPadding of these elements when the viewInsets consumes bottom padding.SafeArea
An optional flag has been added,
maintainBottomViewPadding, to determine if viewPadding should be used over padding when there is an obstruction on the screen. In most cases, the current behavior is desirable, so is the default behavior. When the appearance of a software keyboard causes a layout shift, setting this to true will prevent that change.Other cases
CupertinoTabScaffoldandCupertinoPageScaffoldboth have the resizeToAvoidBottomInsets property, but do not produce this bug. Tests have been added to prevent possible occurrence.In Scaffold, the FloatingActionButton and BottomSheet were unaffected by layout shifts, and tests have been added for these cases as well.
Related Issues
Fixes #29941
Tests
cupertino/tab_scaffold_test.dartcupertino/scaffold.testmaterial/scaffold_test.dartmaterial/snack_bar_test.dartwidgets/safe_area_test.dartChecklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?