Skip to content

Generate ELF shared libraries and allow multi-abi libs in APKs and App bundles #34123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blasten merged 29 commits into from
Jun 10, 2019
Merged

Generate ELF shared libraries and allow multi-abi libs in APKs and App bundles #34123

blasten merged 29 commits into from
Jun 10, 2019

Conversation

@blasten
Copy link

@blasten blasten commented Jun 9, 2019

Retry #33696

Emmanuel Garcia and others added 27 commits June 5, 2019 15:41
@blasten
Generate ELF shared libraries instead of AOT snapshots
24d2d65
@blasten
Allow comma-separated target platforms
f10efb3
@blasten
Look for app.so in intermediates
b7d6c4f
@blasten
Format code
0ec35f2
@blasten
Prevent including libflutter.so twice
a6fa1a6
@blasten
Better name
ab450b9
@blasten
Add test to check for the files in the APK or AAB
0b85809
@blasten
final
7a8502f
@blasten
Linter
fe26a36
@blasten
Support multiple platforms via --target-platform
889558d
@blasten
Test snapshotter
9bc2131
@blasten
targetPlatform -> targetPlatforms
9128987
@blasten
Add message to the stdout to recommend to use app bundles
0fc1144
@blasten
Add flag --split-per-abi to build apk
497abac
@blasten
Address Todd's comments
f3421d0
@blasten
Set->Iterable
04caa92
@blasten
Address feedback
140a90b
@blasten
Add TODO
6f6ac7c
@blasten
const
a8f4e48
@blasten
toList()
86fff8d
@blasten
Address feedback
ecc1782
@blasten
Merge branch 'master' into elf
a8310eb
@blasten
targetPlatform cannot be null anymore
15f4b85
@blasten
Merge branch 'master' into elf
4378f17
@blasten
assembly -> elf
bcf21cd
@blasten
Fix issue in win
2de74ed
@blasten
Fix devicelab
7172199
@blasten blasten requested a review from jonahwilliams June 9, 2019 03:34
@blasten blasten requested a review from tvolkert June 9, 2019 16:10
tvolkert
tvolkert approved these changes Jun 9, 2019
View reviewed changes
Copy link
Contributor

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added t: gradle "flutter build" and "flutter run" on Android tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 10, 2019
@blasten blasten merged commit 8627ff4 into flutter:master Jun 10, 2019
@blasten blasten deleted the elf branch June 10, 2019 20:16
@Hixie
Copy link
Contributor

Hixie commented Jun 11, 2019 •
edited
Loading

If I'm reading the benchmarks correctly, this raised the size of the APK by about 228KB. That seems high. Is that expected?

@blasten
Copy link
Author

blasten commented Jun 11, 2019

@Hixie #34250 will bring the size down.

@Hixie Hixie mentioned this pull request Jun 11, 2019
Closed
@Hixie
Copy link
Contributor

Hixie commented Jun 11, 2019

Excellent!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

1 more reviewer

@tvolkert tvolkert tvolkert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

t: gradle "flutter build" and "flutter run" on Android tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@blasten @Hixie @tvolkert @googlebot @Piinks