Separate web and io implementations of network image #34112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
added
framework
Contributor
Author
Contributor
Author
|
also cc @goderbauer |
jonahwilliams
commented
Jun 10, 2019
jonahwilliams
commented
Jun 10, 2019
jonahwilliams
changed the title
jonahwilliams
commented
Jun 10, 2019
added 2 commits
June 10, 2019 16:49
jonahwilliams
changed the title
jonahwilliams
commented
Jun 11, 2019
harryterkelsen
approved these changes
Jun 11, 2019
Contributor
harryterkelsen
left a comment
harryterkelsen
left a comment
There was a problem hiding this comment.
LGTM, as long as the use of File and Directory to get the asset directory path were just because that is a convenient way to implement it, and not because they needed platform-specific handling of path separators or something
Piinks
added
c: contributor-productivity
goderbauer
reviewed
Jun 12, 2019
added 2 commits
June 13, 2019 12:46
tango5614
added a commit
to tango5614/flutter
that referenced
this pull request
Jun 17, 2019
* master: retry on HttpException (flutter#34526) 308c113 Roll src/third_party/skia 057a32d9a2c8..5fe7429babe2 (1 commits) (flutter/engine#9342) (flutter#34583) Add back ability to override the local engine in Gradle (flutter#34460) Added customizable padding for the segmented controll (flutter#34555) 466a1d8 Roll src/third_party/skia 3721688f64a5..057a32d9a2c8 (1 commits) (flutter/engine#9340) (flutter#34558) Handles parsing APK manifests with additional namespaces or attributes (flutter#34535) add route information to Flutter.Navigation events (flutter#34508) Separate web and io implementations of network image (flutter#34112) pass .packages path to snapshot invocation (flutter#34517) [Material] Fix TextDirection and selected thumb for RangeSliderThumbShape and RangeSliderValueIndicatorShape (flutter#34501) redux of a change to use new engine APIs for Flutter.Frame events (flutter#34521) Roll engine b0757e6..f44b7b5 (4 commits) (flutter#34533) Roll engine 2589785..b0757e6 (6 commits) (flutter#34522) Revert "Revert "redux of a change to use new engine APIs for Flutter.Frame events (flutter#34365)" (flutter#34514)" (flutter#34530) Make sure fab semantics end up on top (flutter#34512) Revert "redux of a change to use new engine APIs for Flutter.Frame events (flutter#34365)" (flutter#34514) redux of a change to use new engine APIs for Flutter.Frame events (flutter#34365)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Both NetworkImage and AssetImage use
dart:iofunctionality that cannot be supported on the web. Similar to what we've done withcompute,bitfield, anddefaultTargetPlatformwe can separate them intoioandwebimplementations, with the latter coming directly from flutter_web.To ensure the interfaces stay consistent, the original class becomes abstract and then redirects to an imported subclass.
There are also other ways these could be split up, by making certain functions public and then importing these.
#34082
Update: The usage of dart:io by AssetImage seems trivial and can be replaced, assuming that we're dealing with file URIs and not file paths.