Skip to content

Add a flag that selects which Android device ID is the target for Flu… #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jason-simmons merged 1 commit into from
Nov 6, 2015
Merged

Add a flag that selects which Android device ID is the target for Flu… #34

jason-simmons merged 1 commit into from
Nov 6, 2015

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Nov 5, 2015

…tter commands

abarth
abarth reviewed Nov 5, 2015
View reviewed changes
packages/flutter_tools/lib/src/build_configuration.dart Outdated
Copy link
Contributor

@abarth abarth Nov 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deviceID -> deviceId

Copy link
Member Author

@jason-simmons jason-simmons Nov 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@abarth
Copy link
Contributor

abarth commented Nov 5, 2015

LGTM

@jason-simmons jason-simmons force-pushed the android_device_id_flag branch from 7d857b5 to 6e0b59f Compare November 5, 2015 23:53
jason-simmons added a commit that referenced this pull request Nov 6, 2015
@jason-simmons
Merge pull request #34 from jason-simmons/android_device_id_flag
e96a609 
Add a flag that selects which Android device ID is the target for Flu…
@jason-simmons jason-simmons merged commit e96a609 into flutter:master Nov 6, 2015
@mpcomplete mpcomplete mentioned this pull request Apr 20, 2016
Closed
@mpcomplete mpcomplete mentioned this pull request Jun 17, 2016
Closed
@mikejurka mikejurka mentioned this pull request Jul 8, 2016
Closed
@jason-simmons jason-simmons mentioned this pull request Jul 21, 2016
Closed
@terrasea terrasea mentioned this pull request Jul 30, 2016
Closed
@mswift42 mswift42 mentioned this pull request Nov 13, 2016
Closed
@gavindoughtie gavindoughtie mentioned this pull request Dec 2, 2016
Closed
@rantianhua rantianhua mentioned this pull request Jan 13, 2017
Closed
@Reagankm Reagankm mentioned this pull request Jan 19, 2017
Closed
@ppolasek ppolasek mentioned this pull request Feb 8, 2017
Closed
@skybrian skybrian mentioned this pull request Feb 16, 2017
Closed
@raphlinus raphlinus mentioned this pull request Feb 23, 2017
Closed
@Reagankm Reagankm mentioned this pull request Feb 24, 2017
Closed
@goodev goodev mentioned this pull request Mar 17, 2017
Closed
@acrozes acrozes mentioned this pull request Mar 18, 2017
Closed
@welldone217 welldone217 mentioned this pull request Apr 21, 2017
Closed
@collinjackson collinjackson mentioned this pull request May 19, 2017
Closed
@LarkAscending LarkAscending mentioned this pull request May 19, 2017
Closed
@cdotstout cdotstout mentioned this pull request Jun 7, 2017
Closed
@jwren jwren mentioned this pull request Jun 15, 2017
Closed
@ericpaepe ericpaepe mentioned this pull request Jun 20, 2017
Closed
@BoaNeo BoaNeo mentioned this pull request Jul 4, 2017
Closed
@DaveShuckerow DaveShuckerow mentioned this pull request Jul 28, 2017
Closed
@jamesgopinath jamesgopinath mentioned this pull request Aug 4, 2017
Closed
@PiechKevin PiechKevin mentioned this pull request Feb 14, 2021
Closed
@RenaSki RenaSki mentioned this pull request Feb 15, 2021
Closed
@Ahmed-Ibrahim-Anter Ahmed-Ibrahim-Anter mentioned this pull request Feb 17, 2021
Closed
@liuxuliangcumt liuxuliangcumt mentioned this pull request Feb 23, 2021
Closed
@hannahgrinton hannahgrinton mentioned this pull request Feb 24, 2021
Closed
@Marko1994 Marko1994 mentioned this pull request Mar 4, 2021
Closed
@lironzemingo lironzemingo mentioned this pull request Mar 11, 2021
Closed
@wangshunji wangshunji mentioned this pull request Mar 12, 2021
Closed
@yannickaboh yannickaboh mentioned this pull request Mar 26, 2021
Closed
@deCardenas deCardenas mentioned this pull request Apr 10, 2021
Closed
@bladeofgod bladeofgod mentioned this pull request Apr 14, 2021
Open
@sanjitsarkar sanjitsarkar mentioned this pull request Apr 24, 2021
Closed
@sauravgpt sauravgpt mentioned this pull request Apr 28, 2021
Closed
@naveedrehman90001 naveedrehman90001 mentioned this pull request May 6, 2021
Closed
@radensoft radensoft mentioned this pull request May 9, 2021
Closed
@sanjitsarkar sanjitsarkar mentioned this pull request May 13, 2021
Closed
@hello-soon hello-soon mentioned this pull request May 21, 2021
Closed
@SlowGen SlowGen mentioned this pull request May 27, 2021
Closed
@Achudh Achudh mentioned this pull request Jun 4, 2021
Closed
@Dalimar95 Dalimar95 mentioned this pull request Jun 8, 2021
Closed
@akashgk akashgk mentioned this pull request Jun 18, 2021
Closed
@SamStrike0809 SamStrike0809 mentioned this pull request Jun 18, 2021
Closed
@94wogus 94wogus mentioned this pull request Jul 3, 2021
Closed
@vaimikpatel2908 vaimikpatel2908 mentioned this pull request Jul 6, 2021
Closed
@JoyEnergiser JoyEnergiser mentioned this pull request Jul 6, 2021
Closed
@nshibu nshibu mentioned this pull request Jul 16, 2021
Closed
@kcibdev kcibdev mentioned this pull request Jul 17, 2021
Closed
@TahaTesser TahaTesser mentioned this pull request Jul 27, 2021
Open
@jonahwilliams jonahwilliams mentioned this pull request Aug 2, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jason-simmons @abarth