Manually roll the engine to land the timing API #33989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyuqian
force-pushed
the
timing_manual_roll
branch
2 times, most recently
from
b08aaa1 to
784edf5
Compare
Member
There was a problem hiding this comment.
The analyzer is flagging this. Should this return _window.onReportTimings?
liyuqian
force-pushed
the
timing_manual_roll
branch
from
784edf5 to
09c2ba2
Compare
This will manually land flutter/engine#8983 in the framework.
liyuqian
force-pushed
the
timing_manual_roll
branch
from
09c2ba2 to
0ffbfea
Compare
Contributor
Author
|
I unexpectedly clicked the rerun for tool_tests-windows. It has actually succeeded in https://cirrus-ci.com/task/5137292092506112 . Hence merge on cancelled tool_tests-windows |
tango5614
added a commit
to tango5614/flutter
that referenced
this pull request
Jun 7, 2019
* master: (25 commits) Increase daemon protocol version for getSupportedPlatforms (flutter#33980) skip web test on crazy import (flutter#34017) Compatibility pass on flutter/foundation tests for JavaScript compilation. (1) (flutter#33349) 0602dbb Roll src/third_party/dart 9dcb026b26..6e0d978505 (72 commits) (flutter#34027) Add chrome stable to dockerfile and web shard (flutter#33787) Codegen an entrypoint for flutter web applications (flutter#33956) Revert "Reland "Text inline widgets, TextSpan rework" (flutter#33946)" (flutter#34002) Revert "Re-add deprecated method for plugin migration compatibility. (flutter#34006)" (flutter#34022) Remove print (flutter#34004) Manual roll the engine to land the timing API (flutter#33989) Make plugins Swift-first on macOS (flutter#33997) Re-add deprecated method for plugin migration compatibility. (flutter#34006) make sure version check includes hotfixes (flutter#33459) Respond to AndroidView focus events. (flutter#33901) Add 'doctor' support for Windows (flutter#33872) Add use_frameworks to macOS Podfile template (flutter#33987) [Material] Create a themable Range Slider (continuous and discrete) (flutter#31681) Updating names to correct versioning convention (flutter#33865) Whitelist adb.exe heap corruption exit code. (flutter#33951) [flutter_tool] Fix 'q' for Fuchsia profile/debug mode (flutter#33846) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will manually land flutter/engine#8983 in the framework.
99e84a9 Update Engine::ReportTimings to use the new FML_TRACE macros (#9215)
9b47dc6 Roll src/third_party/skia 93d0146dc6a1..6e4fee8c812e (8 commits) (#9214)
9f088c6 Add onReportTimings and FrameRasterizedCallback API (#8983)
647a852 Revert "Switch PlatformViewsController from Activity ref to Application ref. (#9193)" (#9211)
1d4f337 Roll src/third_party/skia c5fae22bce20..93d0146dc6a1 (1 commits) (#9209)
2a57255 Roll src/third_party/skia 642178396b09..c5fae22bce20 (3 commits) (#9208)
2bc2cee Roll src/third_party/skia 0f809020ecb0..642178396b09 (2 commits) (#9207)
ca572db Roll src/third_party/skia e0d90c84e42f..0f809020ecb0 (5 commits) (#9205)
3371da1 Add platform_fuchsia.cc for default font on fuchsia (#9204)
7826548 Align fuchsia and non-fuchsia tracing (#9199)
5ea125e Switch PlatformViewsController from Activity ref to Application ref. (#9193)
fd4368c Skip golden tests on non-Linux OSes (#9198)