Codegen an entrypoint for flutter web applications #33956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 5, 2019 16:58
jonahwilliams
added
tool
jonahwilliams
added
platform-web
jonahwilliams
commented
Jun 6, 2019
| @@ -1,16 +0,0 @@ | |||
| // Copyright 2019 The Chromium Authors. All rights reserved. | |||
Contributor
Author
There was a problem hiding this comment.
This is no longer needed, hurrah
yjbanov
approved these changes
Jun 6, 2019
| bool matches = false; | ||
| for (String target in targets) { | ||
| if (buildStep.inputId.path.contains(target)) { | ||
| if (buildStep.inputId.path.contains(fs.path.setExtension(target, '_web_entrypoint.dart'))) { |
Contributor
There was a problem hiding this comment.
Would this not result in blah._web_entrypoint.dart?
Contributor
Author
There was a problem hiding this comment.
Surprisingly not
jakemac53
reviewed
Jun 6, 2019
| ); | ||
| return result.status == core.BuildStatus.success; | ||
| } on core.BuildConfigChangedException { | ||
| projectDirectory |
Contributor
There was a problem hiding this comment.
Ideally you wouldn't delete the entire .dart_tool dir - pub also uses it to cache local dependency snapshots for binaries.
You could delete .dart_tool/build but that would also bash over any other builds.
We do have the functionality to do a more fine grained cleanup, that only deletes the actual known outputs as well, see here https://github.com/dart-lang/build/blob/master/build_runner/lib/src/entrypoint/clean.dart#L41.
Contributor
Author
There was a problem hiding this comment.
Awesome,I tried to adapt that code to this in a way that makes sense
harryterkelsen
approved these changes
Jun 6, 2019
packages/flutter_tools/lib/src/build_runner/web_compilation_delegate.dart
Outdated
Show resolved
Hide resolved
tango5614
added a commit
to tango5614/flutter
that referenced
this pull request
Jun 7, 2019
* master: (25 commits) Increase daemon protocol version for getSupportedPlatforms (flutter#33980) skip web test on crazy import (flutter#34017) Compatibility pass on flutter/foundation tests for JavaScript compilation. (1) (flutter#33349) 0602dbb Roll src/third_party/dart 9dcb026b26..6e0d978505 (72 commits) (flutter#34027) Add chrome stable to dockerfile and web shard (flutter#33787) Codegen an entrypoint for flutter web applications (flutter#33956) Revert "Reland "Text inline widgets, TextSpan rework" (flutter#33946)" (flutter#34002) Revert "Re-add deprecated method for plugin migration compatibility. (flutter#34006)" (flutter#34022) Remove print (flutter#34004) Manual roll the engine to land the timing API (flutter#33989) Make plugins Swift-first on macOS (flutter#33997) Re-add deprecated method for plugin migration compatibility. (flutter#34006) make sure version check includes hotfixes (flutter#33459) Respond to AndroidView focus events. (flutter#33901) Add 'doctor' support for Windows (flutter#33872) Add use_frameworks to macOS Podfile template (flutter#33987) [Material] Create a themable Range Slider (continuous and discrete) (flutter#31681) Updating names to correct versioning convention (flutter#33865) Whitelist adb.exe heap corruption exit code. (flutter#33951) [flutter_tool] Fix 'q' for Fuchsia profile/debug mode (flutter#33846) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generate an entrypoint that is flutter web specific. This avoids needing to reference the "webonly" members for now. ~~ Still need to wire up dart2js with something similar.~~ Done
cc @hterkelsen, I imagine you would use this for plugins too