Add localFocalPoint to ScaleDetector #33955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/cc @mtcliatt |
goderbauer
added
the
framework
mtcliatt
reviewed
Jun 6, 2019
| /// | ||
| /// See also: | ||
| /// | ||
| /// * [localFocalPoint], which is the same value reported in global |
Contributor
There was a problem hiding this comment.
"reported in local" (and on 93)
Sorry for the drive-by review, I was just looking through the commit to learn more and spotted this easy-to-miss slip.
Since I'm here... LGTM! :)
justinmc
approved these changes
Jun 6, 2019
| /// | ||
| /// See also: | ||
| /// | ||
| /// * [localFocalPoint], which is the same value reported in global |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the localFocalPoint to ScaleStartDetails and ScaleUpdateDetails. I forgot to do this in #32192.
Related Issues
Fixes #33818
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?