Skip to content

Revert "Add capability to flutter test --platform=chrome" - #33800

Merged
tvolkert merged 1 commit into
flutter:masterfrom
tvolkert:revert
Jun 3, 2019
Merged

tvolkert merged 1 commit into
flutter:masterfrom
tvolkert:revert

Conversation

@tvolkert

@tvolkert tvolkert commented Jun 3, 2019

Copy link
Copy Markdown
Contributor

This reverts #33525

@jonahwilliams

Copy link
Copy Markdown
Contributor

Why?

@jonahwilliams

Copy link
Copy Markdown
Contributor

NVM, see comment now. Unfortunate, but I can reland using the chrome launcher logic I have pending

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvolkert

tvolkert commented Jun 3, 2019

Copy link
Copy Markdown
Contributor Author

I'm going to land this speculatively and watch the bots post-commit since our dev release is blocking Fuchsia work.

@tvolkert
tvolkert merged commit b835b45 into flutter:master Jun 3, 2019
@tvolkert
tvolkert deleted the revert branch June 3, 2019 21:53
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants