Text inline widgets, TextSpan rework #33794
Conversation
goderbauer
added
the
framework
|
The original PR (#30069) has LGTM |
|
Can you close the old PR if you don't need it anymore and tag this PR with all the tags that were present on the old one? |
GaryQian
added
a: text input
|
@fkorotkov Do you know anything about otherwise similar macos runs taking over twice as long and causing timeouts vs similar runs finishing cleanly? For example, see https://cirrus-ci.com/task/4851206602620928 vs https://cirrus-ci.com/task/5571162709426176 |
|
@GaryQian don't recall seeing such behaviour. 🤔Do you know if dart can output test reports with test duration? Might be helpful to add such reports as artifacts of tasks for troubleshooting similar issues. |
|
cc @GaryQian , the mac luci bot started failing with this PR. I think we should roll it back to verify if this is what pushed it over the edge. |
|
Yeah, ill roll this back for now. It looks like flutter_gallery accessibility_test.dart reordable_list_demo frequently times out with this patch. |
5 participants
COPY OF #30069
New branch to fix versioning issues. See old PR for comments and history
This PR implements the capability of embedding widgets inline into paragraphs.
New TextSpan inheritance structure is the following:
Wrap widgets to embed in
WidgetSpan(widget: <yourwidgethere>)The TextSpan changes make this a breaking change, although existing code passing
<TextSpan>[]intoRichTextorTextPaintershould still work as expected. Only code directly modifying a InlineSpan tree will be affected.Fix/Addition for #2022
Dependent on the engine/LibTxt side PR: flutter/engine#8207