Skip to content

Add documentation to ImplicitlyAnimatedWidgetState #33674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tvolkert merged 2 commits into from
Jun 1, 2019
Merged

Add documentation to ImplicitlyAnimatedWidgetState #33674

tvolkert merged 2 commits into from
Jun 1, 2019

Conversation

@tvolkert
Copy link
Contributor

@tvolkert tvolkert commented May 31, 2019 •
edited
Loading

Description

The documentation for ImplicitlyAnimatedWidgetState was ambiguous in a few places. This PR attempts to clarify those docs.

This is a follow-on to #33370 based on review comments therein.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@tvolkert
Add documentation to ImplicitlyAnimatedWidgetState
b93989d 
This is a follow-on to #33370 based on review comments
therein.
@tvolkert tvolkert requested review from HansMuller and goderbauer May 31, 2019 20:26
@tvolkert tvolkert mentioned this pull request May 31, 2019
Merged
9 tasks
goderbauer
goderbauer approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

HansMuller
HansMuller approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think the forEachTween doc would also be worth clarifying. It would be good if the doc made it crystal clear, at the outset, that the subclass's override needs to apply the visitor callback to each of its tweens (not "animatable facet" even if that's somehow more correct).

@goderbauer goderbauer added the framework flutter/packages/flutter repository. See also f: labels. label May 31, 2019
@tvolkert tvolkert merged commit 31318b0 into flutter:master Jun 1, 2019
@tvolkert tvolkert deleted the docs branch June 1, 2019 22:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@goderbauer goderbauer goderbauer approved these changes

+1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tvolkert @goderbauer @HansMuller @googlebot