Skip to content

Remove obsolete TODOs #33554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dnfield merged 1 commit into from
May 30, 2019
Merged

Remove obsolete TODOs #33554

dnfield merged 1 commit into from
May 30, 2019

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented May 30, 2019

We've been running these tests on Cirrus for a while now - I don't see them going back to the devicelab soon.

I'm also not sure it makes sense to mark the archive issue as a TODO at this point - they changed the API, we now work.

@dnfield dnfield added the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 30, 2019
@dnfield dnfield requested review from digiter and jonahwilliams May 30, 2019 05:57
@dnfield dnfield changed the title Remove obsolete TOODs Remove obsolete TODOs May 30, 2019
jonahwilliams
jonahwilliams approved these changes May 30, 2019
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield dnfield merged commit 0df3ec6 into flutter:master May 30, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@digiter digiter digiter approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dnfield @digiter @jonahwilliams @googlebot