Skip to content

Refresh indicator #3354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HansMuller merged 6 commits into from
Apr 16, 2016
Merged

Refresh indicator #3354

HansMuller merged 6 commits into from
Apr 16, 2016

Conversation

@HansMuller
Copy link
Contributor

@HansMuller HansMuller commented Apr 15, 2016

Adds a RefreshIndicator widget that supports the Material "swipe to refresh" idiom.

Added an over-scroll gallery demo that shows this widget and the existing OverscrollIndicator.

This initial version has some limitations:

  • It always appears at the top and bottom of its scrollable. This should be configurable and it should default to just appearing at the top.
  • During the drag phase, the refresh indicator should only animate when the drag is moving.
  • While the refresh callback is running, the refresh indicator's arrowhead shouldn't appear.
  • It should be possible for the refresh callback to update the indicator with its actual progress.
  • The refresh indicator should disappear "when the user navigates away from the refreshing content".
  • Currently the duration of overscrolls is extended because all drags end in a fling. Both OverscrollIndicator and RefreshIndicator need to cause the Scrollable's ScrollBehavior to set overscroll fling velocities to zero.

See https://www.google.com/design/spec/patterns/swipe-to-refresh.html

Hixie
Hixie reviewed Apr 15, 2016
View reviewed changes
packages/flutter/lib/src/material/progress_indicator.dart Outdated
Copy link
Contributor

@Hixie Hixie Apr 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space after period

@Hixie
Copy link
Contributor

Hixie commented Apr 15, 2016

This needs tests.

@Hixie
Copy link
Contributor

Hixie commented Apr 15, 2016

LGTM with the above comments addressed.

@HansMuller HansMuller merged commit c4ae13e into flutter:master Apr 16, 2016
@HansMuller HansMuller deleted the refresh_indicator branch April 16, 2016 01:39
@sethladd sethladd mentioned this pull request Apr 18, 2016
Closed
8 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2021
Hixie added a commit to Hixie/flutter that referenced this pull request Mar 17, 2023
@Hixie
Documentation improvements
32b37ac 
Fixes flutter#112676.
Fixes flutter#97015.
Fixes flutter#62107.
Fixes flutter#38740.
Fixes flutter#31911.
Fixes flutter#29958.
Fixes flutter#18108.
Fixes flutter#17160.
Fixes flutter#14243.
Fixes flutter#3354.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HansMuller @Hixie