Skip to content

make sure we build test targets too #33284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 1 commit into from
May 26, 2019
Merged

make sure we build test targets too #33284

jonahwilliams merged 1 commit into from
May 26, 2019

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented May 23, 2019 •
edited
Loading

Description

Otherwise codegen inside of the test/ target does not work

Fixes #33266

@jonahwilliams jonahwilliams requested a review from yjbanov May 23, 2019 23:27
@jonahwilliams jonahwilliams added the tool Affects the "flutter" command-line tool. See also t: labels. label May 23, 2019
@jonahwilliams jonahwilliams mentioned this pull request May 23, 2019
Closed
@jonahwilliams jonahwilliams merged commit 582c558 into flutter:master May 26, 2019
@jonahwilliams jonahwilliams deleted the fix_apply_to branch May 26, 2019 02:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flutter generate doesn't generate classes for classes in test folder

3 participants

@jonahwilliams @yjbanov @googlebot