Skip to content

let ListWheelViewport composite again #33070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xster wants to merge 3 commits into from
Closed

let ListWheelViewport composite again #33070

xster wants to merge 3 commits into from

Conversation

@xster
Copy link
Member

@xster xster commented May 20, 2019 •
edited
Loading

Description

Last step in #14224 now that the upstream issue is fixed

Related Issues

Fixes #14224

Tests

This is only really testable via golden which already exists for the list wheel viewport.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@xster xster added the f: cupertino flutter/packages/flutter/cupertino repository label May 20, 2019
@xster xster requested a review from yjbanov May 20, 2019 21:22
@xster
Copy link
Member Author

xster commented May 20, 2019

@jason-simmons I tried turning compositing back on for this widget re:#14224 but after I did so, all the pixels in the golden kinda shifted a little bit (best visible via onion skin diffing:

https://github.com/flutter/goldens/compare/master...xster:listwheel-composite?expand=1

Is this expected?

@jason-simmons
Copy link
Member

jason-simmons commented May 20, 2019

@liyuqian

yjbanov
yjbanov approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if we think that pixel shifting is expected and acceptable.

@liyuqian
Copy link
Contributor

liyuqian commented May 21, 2019

The fix here LGTM. In general, RenderObjects should always respect its needsCompositing bit, which will be true as long as one of its descendants needsCompositing.

@liyuqian
Copy link
Contributor

liyuqian commented May 21, 2019

@xster the small shift is expected: without needsCompositing, the clipRect is recorded in SkPicture, whose top-left corner will be snapped to integer pixel coordinates. With needsCompositing, such snapping doesn't happen.

@xster
Copy link
Member Author

xster commented May 22, 2019

Cool, thanks for the info

@LongCatIsLooong LongCatIsLooong mentioned this pull request Sep 9, 2019
Merged
9 tasks
@gspencergoog
Copy link
Contributor

gspencergoog commented Jan 7, 2020

Hey @xster, are you still working on this PR? If not, can you close it to get it off the PR backlog?

@xster
Copy link
Member Author

xster commented Jan 8, 2020

Oh @LongCatIsLooong did it in #47837. Win!

@xster xster closed this Jan 8, 2020
@xster xster deleted the listwheel-composite branch January 8, 2020 03:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yjbanov yjbanov yjbanov approved these changes

+1 more reviewer

@liyuqian liyuqian liyuqian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ListWheelViewport should set needsCompositing

6 participants

@xster @jason-simmons @liyuqian @gspencergoog @yjbanov @googlebot