Skip to content

Conversation

@gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented May 15, 2019

Description

This adds support for an animated focusColor and hoverColor to InputDecorator. This color will blend with the background over a fade in period whenever the InputDecorator is focused or hovered, respectively.

It also adds a Listener to the TextField to listen for hover events.

Tests

I added the following tests:

  • A test to make sure that focusColor is drawn and animates when focus changes.
  • A test to make sure that hoverColor is drawn and animates when hovering.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@gspencergoog gspencergoog force-pushed the text_field_focus branch 2 times, most recently from 594d043 to 93d71b9 Compare May 15, 2019 21:33
@gspencergoog gspencergoog requested a review from HansMuller May 15, 2019 21:43
@HansMuller HansMuller added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 16, 2019
@gspencergoog gspencergoog changed the title Text field focus Text field focus and hover support. May 16, 2019
@gspencergoog gspencergoog requested a review from darrenaustin May 16, 2019 21:13
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the extraneous print statement, LGTM.

@gspencergoog gspencergoog merged commit 9f21ae0 into flutter:master May 17, 2019
@gspencergoog gspencergoog deleted the text_field_focus branch June 5, 2019 20:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants