Skip to content

Conversation

@esarbanis
Copy link
Contributor

Description

Fixes typo and logical errors in _WidgetsAppState.basicLocaleListResolution apidocs

Related Issues

Fixes #29894

Tests

I added the following tests:

No tests were needed for this documentation changes.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@dnfield dnfield requested a review from GaryQian May 14, 2019 17:51
@dnfield dnfield added the d: api docs Issues with https://api.flutter.dev/ label May 14, 2019
@dnfield
Copy link
Contributor

dnfield commented May 14, 2019

I think this is correct but @GaryQian should know for sure.

@Piinks Piinks added the framework flutter/packages/flutter repository. See also f: labels. label May 16, 2019
Copy link
Contributor

@GaryQian GaryQian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! LGTM!

@GaryQian GaryQian merged commit c6be1b9 into flutter:master May 21, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

d: api docs Issues with https://api.flutter.dev/ framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

the comment of file flutter/packages/flutter/lib/src/widgets/app.dart has error

5 participants