Skip to content

Fix benchmark regression in layer.find<S>(Offset) - #32425

Merged
gspencergoog merged 1 commit into
flutter:masterfrom
gspencergoog:nested_listeners
May 9, 2019
Merged

gspencergoog merged 1 commit into
flutter:masterfrom
gspencergoog:nested_listeners

Conversation

@gspencergoog

Copy link
Copy Markdown
Contributor

Description

This fixes a benchmark regression introduced in #32350. The performance is improved by just reverting the Layer.find<S> routines to use their old definitions, instead of defining them in terms of the findAll<S> lazy iterators.

Related Issues

Fixes #32387

@gspencergoog
gspencergoog requested a review from jonahwilliams May 9, 2019 17:30
@gspencergoog gspencergoog changed the title Fix benchmark regression. Fix benchmark regression in layer.find<S>(Offset) May 9, 2019
@gspencergoog
gspencergoog force-pushed the nested_listeners branch 2 times, most recently from a186b7d to 79c7700 Compare May 9, 2019 18:16

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jonahwilliams

Copy link
Copy Markdown
Contributor

Should we consider replacing the sync* implementation with something that returns a List (once we have a benchmark covering it?).

@gspencergoog

Copy link
Copy Markdown
Contributor Author

Yeah, maybe. I'll look at that after this.

@gspencergoog
gspencergoog merged commit 66a6726 into flutter:master May 9, 2019
@gspencergoog
gspencergoog deleted the nested_listeners branch May 15, 2019 16:29
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Performance Regression

3 participants