Skip to content

Conversation

@darrenaustin
Copy link
Contributor

Description

Adds a feature of the native Android Time Picker to our Material Time Picker. When the user selects an hour, it automatically switches to minute mode.

This is a merging of two pull requests:

Thanks to both of you for your contributions!

Related Issues

Fixes #17276, #29600

Tests

The following tests were added from @lucaslcode:

'tap-select switches from hour to minute'
'drag-select switches from hour to minute'

to time_picker_test.dart.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

This is a merging of two pull requests:
- Code changes from @sdolski
- Tests from @lucaslcode
@darrenaustin darrenaustin added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Apr 24, 2019
@darrenaustin darrenaustin requested a review from HansMuller April 24, 2019 17:54
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some trivial changes

- Added more asserts for the _Dial constructor
- Null guarded the onHourSelected callback
- Extracted some variables in the test to make it more explicit what it was doing.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TimePicker doesn't switch to minute after selecting hour like the Android native time picker does

3 participants