Roll engine ca31a7c57bad..bd8c5b135e4d (12 commits) #31330
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Trybots failed. These were the failed builds: https://cirrus-ci.com/task/4704667236827136 |
Contributor
Author
|
Commit queue failed; closing this roll. |
liyuqian
added a commit
to flutter/engine
that referenced
this pull request
Apr 22, 2019
This reverts commit bd8c5b1. Reverts #8656 Reason: #8656 seems to break the framework windows tests and the engine roll (see https://cirrus-ci.com/task/4704667236827136 and flutter/flutter#31330). The failure has been consistent for 7 consecutive engine-to-framework auto-rolls. TBR: @chinmaygarde
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/engine@ca31a7c...bd8c5b1
git log ca31a7c..bd8c5b1 --no-merges --oneline
bd8c5b1 Only allow mappings for ICU initialization. (flutter/engine#8656)
206cab6 Roll src/third_party/skia cc5d3e09e394..1c0b05afdef8 (14 commits) (flutter/engine#8654)
1fe3279 Cleanup references to FLX archives from the engine. (flutter/engine#8653)
6257dfe Add factory methods to FileMapping that make it easy to create common mappings. (flutter/engine#8652)
5fed725 Roll buildroot to 380d0ed (flutter/engine#8649)
eaa0e9c Roll src/third_party/skia e5763787f920..cc5d3e09e394 (3 commits) (flutter/engine#8651)
7e37080 Allow specifying the Mac SDK path as an environment variable to //flutter/tools/gn (flutter/engine#8643)
30c23e6 Roll src/third_party/skia e8a33ec6d084..e5763787f920 (1 commits) (flutter/engine#8650)
8f0af31 Roll src/third_party/skia 8cdae55bf1ac..e8a33ec6d084 (3 commits) (flutter/engine#8648)
25c33dc Roll src/third_party/skia 9b67802a4cd0..8cdae55bf1ac (1 commits) (flutter/engine#8647)
1e5f59d Reland "Remove DartSnapshotBuffer and dry up snapshot resolution logic". (flutter/engine#8645)
4ead9c8 Remove unused Settings::ToString. (flutter/engine#8642)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.