WIP TextField Vertical Alignment #31079
Conversation
Hixie
added
f: material design
|
@HansMuller I need your advice on this. Someone opened an issue (#29927) because tall text fields with an outline vertically center the text:
But without an outline it's aligned to the top:
I think this was on purpose originally, but the material spec may have since changed, because Will is saying that all multiline inputs should be aligned to the top: #29927 (comment) There are several things we could do here, from providing param(s) to allow the user to set the vertical alignment, to getting rid of vertical centering altogether. What do you think? |
|
@justinmc I don't think it would be a good idea to change the default layout of (multiline) outlined textfields however I agree that the aligning the text to the top makes more visual sense. The safest path would be to introduce a parameter that does the job. It might be useful to define this new parameter in a way that allows for bottom-alignment, or arbitrary vertical alignment. |
|
After discussing this, I am going to investigate providing a new parameter that specifies the vertical alignment as a range, with top, center, and bottom constants. |
|
Note to self: make sure that the solution here considers the |
justinmc
force-pushed
the
text-field-vertical-align
branch
4 times, most recently
from
a20348e to
654e8e6
Compare
justinmc
force-pushed
the
text-field-vertical-align
branch
from
8b2f48c to
33df0c5
Compare
justinmc
force-pushed
the
text-field-vertical-align
branch
from
33df0c5 to
25c8400
Compare
|
I just messed this PR up badly somehow... It is not merged into master. I will try to recover my code and open a new PR. |
4 participants
Closes #29927
TextFields currently vertically center their text when they have an outline border. The difference between this and top alignment is almost nothing in most cases except when the input is very tall (see issue). We need to decide if we need that vertically centering functionality at all, and if so, when exactly.
Currently, this PR is just an exploration of how we could force top alignment, since according to #29927 (comment), we may not need this vertical centering at all.