Skip to content

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Apr 12, 2019

Description

In flutter/engine#8565, I'm proposing we change some caching for RRect.contains. This will track if that causes a perf regression.

Related Issues

flutter/engine#8565

Tests

I added the following tests:

New benchmark.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@dnfield dnfield requested a review from Hixie April 12, 2019 21:59
@dnfield dnfield added a: tests "flutter test", flutter_test, or one of our tests c: performance Relates to speed or footprint issues (see "perf:" labels) and removed cla: yes labels Apr 12, 2019
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield dnfield removed the request for review from Hixie April 12, 2019 23:47
@jonahwilliams jonahwilliams merged commit 99bd279 into flutter:master Apr 15, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: tests "flutter test", flutter_test, or one of our tests c: performance Relates to speed or footprint issues (see "perf:" labels)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants