Bump Android build tools to 28.0.3 in Dockerfile #30832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM. I think we actually updated the build tools requirement in flutter doctor since the docker image was built. However - I believe any actual gradle activity should end up downloading the right buildtools version. Flutter doctor by itself just doesn't trigger that. |
Member
|
LGTM |
Contributor
Author
|
Interesting. @dnfield but why was it succeeding before and not after we updated the Docker image? Bumping the version seemed to have fixed that, but maybe it was just masked by something else before? |
gspencergoog
force-pushed
the
update_docker
branch
from
ac3ad1c to
78fd24d
Compare
Contributor
|
That I'm not sure of. Perhaps someone (probably me?) updated the buildtools and forgot to checkin the docker file :( |
goderbauer
added
the
c: contributor-productivity
jiisd
added a commit
to jiisd/flutter
that referenced
this pull request
Apr 12, 2019
* master: (209 commits) Allow mouse hover to only respond to some mouse events but not all. (flutter#30886) Fix issue 23527: Exception: RenderViewport exceeded its maximum number of layout cycles (flutter#30809) Keep hover annotation layers in sync with the mouse detector. (flutter#30829) Use identical instead of '==' in a constant expression. (flutter#30921) Add toggle for debugProfileWidgetBuilds (flutter#30867) Revert "Manual engine roll with disabled service authentication codes (flutter#30919)" (flutter#30930) Manual engine roll with disabled service authentication codes (flutter#30919) Baseline Aligned Row (flutter#30746) [Material] Fix showDialog crasher caused by old contexts (flutter#30754) Let `sliver.dart` `_createErrorWidget` work with other Widgets (flutter#30880) Add more dialog doc cross-reference (flutter#30887) Allow downloading of desktop embedding artifacts (flutter#30648) CupertinoDatePicker initialDateTime accounts for minuteInterval (flutter#30862) add golden tests for CupertinoDatePicker (flutter#30828) Simplify toImage future handling (flutter#30876) Fixed Table flex column layout error flutter#30437 (flutter#30470) Fix iTunes Transporter quirk (flutter#30883) Bump Android build tools to 28.0.3 in Dockerfile (flutter#30832) Update the upload key which seems to have trouble for some reason (flutter#30871) Check for invalid elevations (flutter#30215) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the Android build tools to 28.0.3 instead of 28.0.0 in the
Dockerfile, since that is whatflutter doctorwants.It seems that someone may have built the docker image without making this change to the
Dockerfile, which meant that the next time someone pushed, it didn't build the right image.