add golden tests for CupertinoDatePicker #30828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LongCatIsLooong
added
f: cupertino
dnfield
reviewed
Apr 10, 2019
dnfield
reviewed
Apr 10, 2019
LongCatIsLooong
force-pushed
the
add-golden-tests-for-cupertiono-datepicker
branch
from
58b985c to
acdf785
Compare
Contributor
|
@fkorotkov - The git errors on these windows builds seem strange - looks like Git isn't configured properly on Windows instances right now. |
Contributor
|
Nothing has changed to the images in the last weeks https://hub.docker.com/r/cirrusci/android-sdk/tags and it seems it's passing for master 🤔 |
fkorotkov
added a commit
to cirruslabs/docker-images-android
that referenced
this pull request
Apr 10, 2019
Related to flutter/flutter#30828
fkorotkov
added a commit
to cirruslabs/docker-images-android
that referenced
this pull request
Apr 10, 2019
Contributor
|
I've added cirruslabs/docker-images-android#10 which should help with the issue but I still wonder why it started happening suddenly. New images will be available in ~30 minutes so you can retry. |
xster
reviewed
Apr 10, 2019
xster
reviewed
Apr 10, 2019
jiisd
added a commit
to jiisd/flutter
that referenced
this pull request
Apr 12, 2019
* master: (209 commits) Allow mouse hover to only respond to some mouse events but not all. (flutter#30886) Fix issue 23527: Exception: RenderViewport exceeded its maximum number of layout cycles (flutter#30809) Keep hover annotation layers in sync with the mouse detector. (flutter#30829) Use identical instead of '==' in a constant expression. (flutter#30921) Add toggle for debugProfileWidgetBuilds (flutter#30867) Revert "Manual engine roll with disabled service authentication codes (flutter#30919)" (flutter#30930) Manual engine roll with disabled service authentication codes (flutter#30919) Baseline Aligned Row (flutter#30746) [Material] Fix showDialog crasher caused by old contexts (flutter#30754) Let `sliver.dart` `_createErrorWidget` work with other Widgets (flutter#30880) Add more dialog doc cross-reference (flutter#30887) Allow downloading of desktop embedding artifacts (flutter#30648) CupertinoDatePicker initialDateTime accounts for minuteInterval (flutter#30862) add golden tests for CupertinoDatePicker (flutter#30828) Simplify toImage future handling (flutter#30876) Fixed Table flex column layout error flutter#30437 (flutter#30470) Fix iTunes Transporter quirk (flutter#30883) Bump Android build tools to 28.0.3 in Dockerfile (flutter#30832) Update the upload key which seems to have trouble for some reason (flutter#30871) Check for invalid elevations (flutter#30215) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add golden tests for
CupertinoDatePickerdependent on golden files: flutter/goldens#29
Related Issues
#30801
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?