Baseline Aligned Row #30746
Merged
Baseline Aligned Row #30746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
added
f: material design
HansMuller
reviewed
Apr 10, 2019
Contributor
HansMuller
left a comment
HansMuller
left a comment
There was a problem hiding this comment.
This is a really nice fix, and long overdue! The analyzer wants some const expressions and I think the test could be tightened up just a little.
|
|
||
| group('Row', () { | ||
| testWidgets('multiple baseline aligned children', (WidgetTester tester) async { | ||
| final GlobalKey key1 = GlobalKey(); |
Contributor
There was a problem hiding this comment.
GlobalKeys shouldn't be needed here, Key key1 = UniqueKey() should be enough.
| // contain both of them. | ||
| expect(rowBox.size.height, greaterThan(textBox1.size.height)); | ||
| expect(rowBox.size.height, greaterThan(textBox2.size.height)); | ||
| expect(rowBox.size.height, lessThan(textBox1.size.height + textBox2.size.height)); |
Contributor
There was a problem hiding this comment.
We should be able to predict the row's exact overall height and the top or bottom edge of the two text widgets.
Contributor
Author
There was a problem hiding this comment.
You're right, I was able to calculate the right height.
Contributor
Author
|
@HansMuller Ready for re-review. |
jiisd
added a commit
to jiisd/flutter
that referenced
this pull request
Apr 12, 2019
* master: (209 commits) Allow mouse hover to only respond to some mouse events but not all. (flutter#30886) Fix issue 23527: Exception: RenderViewport exceeded its maximum number of layout cycles (flutter#30809) Keep hover annotation layers in sync with the mouse detector. (flutter#30829) Use identical instead of '==' in a constant expression. (flutter#30921) Add toggle for debugProfileWidgetBuilds (flutter#30867) Revert "Manual engine roll with disabled service authentication codes (flutter#30919)" (flutter#30930) Manual engine roll with disabled service authentication codes (flutter#30919) Baseline Aligned Row (flutter#30746) [Material] Fix showDialog crasher caused by old contexts (flutter#30754) Let `sliver.dart` `_createErrorWidget` work with other Widgets (flutter#30880) Add more dialog doc cross-reference (flutter#30887) Allow downloading of desktop embedding artifacts (flutter#30648) CupertinoDatePicker initialDateTime accounts for minuteInterval (flutter#30862) add golden tests for CupertinoDatePicker (flutter#30828) Simplify toImage future handling (flutter#30876) Fixed Table flex column layout error flutter#30437 (flutter#30470) Fix iTunes Transporter quirk (flutter#30883) Bump Android build tools to 28.0.3 in Dockerfile (flutter#30832) Update the upload key which seems to have trouble for some reason (flutter#30871) Check for invalid elevations (flutter#30215) ...
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24705
There was a crash when putting a TextField in a row aligned by baseline. I cherry picked the fix for this part from @GaryQian's upcoming PR #30069.
Also, the height of the row was not being calculated correctly when aligned by baseline, but is fixed in this PR.
For example, the very tall
counteron this text field overflows the red Row container. With this PR, it will fit perfectly inside.