WIP: Make more widgets const constructable #30646
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This WIP PR exists solely to demonstrate dart-lang/sdk#36511 |
dnfield
reviewed
Apr 9, 2019
Contributor
There was a problem hiding this comment.
Maybe just with a TODO linking to dart-lang/sdk#29278 ? That's marked as something that will be fixed someday.
Contributor
Author
There was a problem hiding this comment.
It's kinda moot since I can't merge this PR with the commented-out assert in MultiChildRenderObjectWidget.
goderbauer
added
framework
Contributor
Author
|
Closing this for now, and will revisit once non-nullability in Dart lands. |
|
Now that non-nullability is here, is this likely to be revisited soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.