Add hintStyle in SearchDelegate #30388

guojiex · 2019-04-02T15:05:32Z

Description

Add hintStyle in SearchDelegate.
so that user can customize hint text color by overriding appBarTheme function in their code.

Related Issues

#19734

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I signed the CLA.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I updated/added relevant documentation (doc comments with ///).
All existing and new tests are passing.
The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
No, this is not a breaking change.

Sync my fork of flutter

… color by overriding appBarTheme function in their code. See #19734

guojiex · 2019-04-04T17:22:59Z

Can anyone take a look of the code, it is just one line of code.. should be quick...

rami-a

Thanks for the PR, please add a test for the hint style change.

guojiex · 2019-04-29T14:44:59Z

Done. Simple unit test added.

rami-a

Just a few minor formatting things

packages/flutter/test/material/search_test.dart

rami-a · 2019-04-29T15:06:59Z

packages/flutter/test/material/search_test.dart

+    await tester.tap(find.byTooltip('Search'));
+    await tester.pumpAndSettle();
+    expect(
+        tester


The format of this is a little tough to follow. I suggest something like this:

final TextField textField = tester.widget<TextField>(find.byType(TextField)); final Color hintColor = textField.decoration.hintStyle.color; expect(hintColor, delegate.hintTextColor);

rami-a

LGTM! Passing off to @HansMuller for final approval. Thanks!

rami-a · 2019-04-29T17:06:42Z

packages/flutter/lib/src/material/search.dart

            decoration: InputDecoration(
              border: InputBorder.none,
              hintText: searchFieldLabel,
+              hintStyle: theme.inputDecorationTheme.hintStyle,


Sorry @guojiex, after thinking about this a little more, it seems like there exists a bug somewhere deeper. Inside text_field.dart in _getEffectiveDecoration it should apply the theme values to the decoration and so the hintStyle should be passed along that way.

Could you please take a look as to why this isn't happening and see if there is fix that can be applied more broadly to TextFields? Thanks!

When I run the unit test:
_getEffectiveDecoration() is called when render, and it can correctly show the hintstyle.
But the TextField.decoration is final and init only once, it will not show the hintstyle if not given(if the line in this pull request is not added).

But when I run a real app in emulator. At the time _getEffectiveDecoration is called, the hintstyle is always null, or TextStyle(inherit: true, color: Color(0xffffffff)), which is not overridden by appBarTheme function.

@rami-a Sorry if I'm misunderstanding the discussion but to me it seems as the ThemeData (from appbarTheme) doesn't wrap the AppBar, rather the values are sort of 'cherry picked' from it in search.dart, when it comes to getting the themeData.inputDecorationTheme in _getEffectiveDecoration, the theme values are just those of the application. So this isn't a Text Field issue, rather one an issue with the search delegate?

I agree with @NBTX. appBarTheme provided in the SearchDelegate is not set as the theme for the context. Instead, a few of its properties are "cherry picked" and set on the AppBar and the TextField. When TextField grabs values from the theme, it is looking at the overall app theme and not SearchDelegate's appBarTheme.

If you set hintColor in the app theme then it will be respected by the Search TextField. If you set it in appBarTheme it will be ignored (without this PR).

Overall it seems like this pattern is confusing and there is probably a better way to handle this sort of theming, but for now, I think this PR looks like a good improvement. @rami-a What do you think about moving forward with merging this?

Yeah after looking at it more, I think this makes sense for now.

rami-a

On second thought, I believe there may exist a bug deeper, perhaps within TextFields. If you could please investigate where the bug may be happening, as in theory this change shouldn't be needed. Thanks

guojiex · 2019-04-29T18:50:16Z

There is another pull request that is the same as mine:
#28165

guojiex · 2019-04-30T15:00:41Z

_getEffectiveDecoration() is called when render, and it can correctly show the hintstyle.
But the TextField.decoration is final and init only once, it will not show the hintstyle if not given.

The decoration field in TextField is not correctly showing what will be rendered.

mdusafp · 2019-05-11T23:48:34Z

Is it possible to merge it next version this fix?

hyperpanthera · 2019-05-12T23:33:15Z

Please merge this already.

mikuhl-dev · 2019-06-08T10:52:33Z

Want this

hyperpanthera · 2019-06-08T10:57:19Z

@MichaelPriebe Sadly some pull requests go unnoticed.

mikuhl-dev · 2019-06-08T11:03:34Z

SUbMiT puLl rEquEsts TO Help oUr opeN soUrCE PrOJecT

mikuhl-dev · 2019-06-11T18:50:20Z

Woohoo! Now onto #28807 choo choo!!

commit 92e52d5 Merge: 421e4e4 da6dde6 Author: jonahwilliams <[email protected]> Date: Wed Jun 12 14:12:36 2019 -0700 Merge branch 'master' of github.com:flutter/flutter into add_network_image_impl commit 421e4e4 Author: jonahwilliams <[email protected]> Date: Wed Jun 12 14:03:11 2019 -0700 address comments commit da6dde6 Author: engine-flutter-autoroll <[email protected]> Date: Wed Jun 12 16:49:55 2019 -0400 Roll engine ab5c14b..67aadb6 (2 commits) (flutter#34350) flutter/engine@ab5c14b...67aadb6 git log ab5c14b..67aadb6 --no-merges --oneline 67aadb6 Roll src/third_party/skia d62d406aa24c..81756e4cae95 (5 commits) (flutter/engine#9300) 0a2e28d Revert tracing changes (flutter/engine#9296) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary. commit 8163c0a Author: Todd Volkert <[email protected]> Date: Wed Jun 12 13:47:47 2019 -0700 Re-apply compressionState changes. (flutter#34341) This re-applies the changes that were made in flutter#33697 and flutter#33729, but which were reverted in flutter#33792 and flutter#33790, respectively due to the Dart SDK not having received the update within Google yet. The SDK has now rolled, so these changes can be re-applied. flutter#32374 flutter#33791 commit 25c8400 Author: Devon Carew <[email protected]> Date: Wed Jun 12 13:14:20 2019 -0700 Revert "update the Flutter.Frame event to use new engine APIs (flutter#34243)" (flutter#34352) This reverts commit 446179f. commit c40d701 Author: Jenn Magder <[email protected]> Date: Wed Jun 12 11:31:17 2019 -0700 Change Xcode project developmentRegion to 'en' and plist CFBundleDevelopmentRegion to DEVELOPMENT_LANGUAGE (flutter#34293) commit 446179f Author: Devon Carew <[email protected]> Date: Wed Jun 12 11:20:10 2019 -0700 update the Flutter.Frame event to use new engine APIs (flutter#34243) * update the Flutter.Frame event to use new engine APIs * add a test * update test commit 22ca3f9 Author: Zachary Anderson <[email protected]> Date: Wed Jun 12 11:18:53 2019 -0700 [flutter_tool] Don't truncate verbose logs from _flutter.listViews (flutter#34255) commit 75b5cec Author: engine-flutter-autoroll <[email protected]> Date: Wed Jun 12 14:03:56 2019 -0400 ab5c14b Set Dart version to git hash 3166bbf24b0c929eef33fd5d0f69e0f36a9009f3 (Dart 2.3.3-dev) (flutter/engine#9292) (flutter#34336) flutter/engine@d3c213e...ab5c14b git log d3c213e..ab5c14b --no-merges --oneline ab5c14b Set Dart version to git hash 3166bbf24b0c929eef33fd5d0f69e0f36a9009f3 (Dart 2.3.3-dev) (flutter/engine#9292) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary. commit fb2f18e Author: Todd Volkert <[email protected]> Date: Wed Jun 12 10:22:50 2019 -0700 Prepare for Uint8List SDK breaking changes (flutter#34295) dart-lang/sdk#36900 commit bdd0724 Author: engine-flutter-autoroll <[email protected]> Date: Wed Jun 12 13:03:55 2019 -0400 Roll engine b14d971..d3c213e (3 commits) (flutter#34331) flutter/engine@b14d971...d3c213e git log b14d971..d3c213e --no-merges --oneline d3c213e Roll src/third_party/skia 698fa78b3cae..d62d406aa24c (1 commits) (flutter/engine#9295) 4d7afb9 Roll src/third_party/skia ed7966f179c6..698fa78b3cae (1 commits) (flutter/engine#9294) 05e1b6e Roll src/third_party/skia d82ca0bf2c99..ed7966f179c6 (2 commits) (flutter/engine#9293) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary. commit fa174a1 Author: engine-flutter-autoroll <[email protected]> Date: Wed Jun 12 00:45:55 2019 -0400 Roll engine 4fc95eb..b14d971 (4 commits) (flutter#34310) flutter/engine@4fc95eb...b14d971 git log 4fc95eb..b14d971 --no-merges --oneline b14d971 Roll src/third_party/skia f39124b0764d..d82ca0bf2c99 (3 commits) (flutter/engine#9291) 87c26ae Refactor Delayed Tasks to their own file (flutter/engine#9290) 9baf589 [iOS] [a11y] Don&flutter#39;t allow scroll views to grab a11y focus (flutter/engine#9282) f80ac5f [fuchsia] Fix alignment of Fuchsia/non-Fuchsia tracing (flutter/engine#9289) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary. commit 70840d4 Author: engine-flutter-autoroll <[email protected]> Date: Tue Jun 11 23:41:58 2019 -0400 4fc95eb Fixed memory leaks within FlutterFragment and FlutterView (flutter#34268, flutter#34269, flutter#34270). (flutter/engine#9288) (flutter#34305) commit d6425a2 Author: engine-flutter-autoroll <[email protected]> Date: Tue Jun 11 21:54:55 2019 -0400 Roll engine 2d2cfc0..de350c4 (2 commits) (flutter#34302) flutter/engine@2d2cfc0...de350c4 git log 2d2cfc0..de350c4 --no-merges --oneline de350c4 Report timings faster (100ms) in profile/debug (flutter/engine#9287) 6dc4d6c Add refresh callback to GLFW shell (flutter/engine#9280) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary. commit 9a46b3e Author: engine-flutter-autoroll <[email protected]> Date: Tue Jun 11 20:17:55 2019 -0400 Roll engine 02e6a13..2d2cfc0 (3 commits) (flutter#34292) flutter/engine@02e6a13...2d2cfc0 git log 02e6a13..2d2cfc0 --no-merges --oneline 2d2cfc0 Expose a hasRenderedFirstFrame() method in FlutterView (flutter#34275). (flutter/engine#9285) 8040117 Fix TextInputPlugin NPE caused by PlatformViewsController ref in new embedding (flutter#34283). (flutter/engine#9283) c7b25f1 Roll src/third_party/skia df586b7d568d..f39124b0764d (11 commits) (flutter/engine#9284) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary. commit 21a5326 Author: Emmanuel Garcia <[email protected]> Date: Tue Jun 11 16:24:03 2019 -0700 Split gradle_plugin_test.dart (flutter#34282) Fixes timeout when running gradle_plugin_test commit 8247963 Author: engine-flutter-autoroll <[email protected]> Date: Tue Jun 11 18:30:55 2019 -0400 Roll engine 4d68474..02e6a13 (4 commits) (flutter#34281) flutter/engine@4d68474...02e6a13 git log 4d68474..02e6a13 --no-merges --oneline 02e6a13 Roll src/third_party/dart 7ecd81b0b8..b37aa3b036 (4 commits) (flutter/engine#9272) 95f9b3d Fix crash on minimize with GLFW shell (flutter/engine#9278) 8d017fa Roll src/third_party/skia a716809d5ad3..df586b7d568d (17 commits) (flutter/engine#9279) 10a3ab0 Fix missing return lint (flutter/engine#9246) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary. commit 9d724d4 Author: Jonah Williams <[email protected]> Date: Tue Jun 11 14:51:03 2019 -0700 Compatibility pass on flutter/widgets tests for JavaScript compilation. (8) (flutter#33377) commit d9c1962 Author: Emmanuel Garcia <[email protected]> Date: Tue Jun 11 14:46:00 2019 -0700 Instrument usage of include_flutter.groovy and xcode_backend.sh (flutter#34189) This is done via `flutter build bundle`. As a consequence, this PR introduces a new way to disable analytics via the `FLUTTER_SUPPRESS_ANALYTICS` env flag. commit 1eb8c64 Author: LongCatIsLooong <[email protected]> Date: Tue Jun 11 14:14:54 2019 -0700 Fix CupertinoTabScaffold index out of range (flutter#33624) commit 89d887f Author: Jason Simmons <[email protected]> Date: Tue Jun 11 13:34:24 2019 -0700 Strip debug symbols from ELF library snapshots (flutter#34250) AOT compiled code is now packaged as an ELF library for Android targets. By default gen_snapshot's output contains debug symbols. The symbols could be stripped as a separate step, but that requires NDK tools that the user may not have available. This change passes a gen_snapshot flag that omits the symbols, and it filters out a warning printed when that flag is used. commit 6d0e618 Author: engine-flutter-autoroll <[email protected]> Date: Tue Jun 11 15:55:56 2019 -0400 Roll engine de420a0..4d68474 (3 commits) (flutter#34258) flutter/engine@de420a0...4d68474 git log de420a0..4d68474 --no-merges --oneline 4d68474 Load AOT compiled Dart assets only from ELF libraries (flutter/engine#9260) 3e9ffe1 Whitelist the —enable_mirrors flag to fix regression in existing embedder. (flutter/engine#9266) 7cde42c Unbreak internal rolls (flutter/engine#9270) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary. commit e59d9a8 Author: Ben Konyi <[email protected]> Date: Tue Jun 11 11:37:47 2019 -0700 Reland "Added --dart-flags option to flutter run (flutter#33924)" (flutter#34181) Reland "Added --dart-flags option to flutter run (flutter#33924)" This reverts commit 587687e. commit 7cc7161 Author: Jonah Williams <[email protected]> Date: Tue Jun 11 11:22:37 2019 -0700 Compatibility pass on flutter/semantics tests for JavaScript compilation. (7) (flutter#33360) commit 1bc8402 Author: guoskyhero <[email protected]> Date: Tue Jun 11 11:15:50 2019 -0700 Add hintStyle in SearchDelegate (flutter#30388) SearchDelegate hintStyle parameter commit 336e4c4 Author: engine-flutter-autoroll <[email protected]> Date: Tue Jun 11 14:12:56 2019 -0400 Roll engine c9bbd0e..de420a0 (4 commits) (flutter#34247) flutter/engine@c9bbd0e...de420a0 git log c9bbd0e..de420a0 --no-merges --oneline de420a0 Roll src/third_party/dart 97f91fecdb..7ecd81b0b8 (5 commits) (flutter/engine#9268) 8812781 Roll src/third_party/skia bba5aa761cd5..a716809d5ad3 (1 commits) (flutter/engine#9269) b470913 Roll src/third_party/skia 77cb2ca3c9aa..bba5aa761cd5 (3 commits) (flutter/engine#9267) 48ecbca Roll src/third_party/skia bb74990a11d9..77cb2ca3c9aa (1 commits) (flutter/engine#9265) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary. commit 7feddfd Author: Jonah Williams <[email protected]> Date: Tue Jun 11 10:35:10 2019 -0700 make sure this test doesnt run for real (flutter#34199) commit d850d69 Author: Neevash Ramdial <[email protected]> Date: Tue Jun 11 12:57:17 2019 -0400 Added tool sample for PageController (flutter#34137) * Added tool sample for PageController * Fixed text directionality bug commit 05e92c8 Author: Jonah Williams <[email protected]> Date: Tue Jun 11 09:09:13 2019 -0700 Compatibility pass on flutter/physics tests for JavaScript compilation. (6) (flutter#33359) commit 30fb980 Author: engine-flutter-autoroll <[email protected]> Date: Tue Jun 11 11:41:47 2019 -0400 c9bbd0e Roll src/third_party/dart 7f146e431e..97f91fecdb (22 commits) (flutter#34203) commit e9ca112 Author: LongCatIsLooong <[email protected]> Date: Mon Jun 10 19:17:55 2019 -0700 update CupertinoDialogAction isDefaultAction documentation (flutter#34163) commit fcaf96d Author: engine-flutter-autoroll <[email protected]> Date: Mon Jun 10 21:35:55 2019 -0400 Roll engine f3ab2e4..4c0daac (2 commits) (flutter#34197) flutter/engine@f3ab2e4...4c0daac git log f3ab2e4..4c0daac --no-merges --oneline 4c0daac Roll src/third_party/skia cb1adb40d0f3..bb74990a11d9 (3 commits) (flutter/engine#9261) 2d0103a Removed VIRTUAL_KEYBOARD check in TextInputPlugin because it&flutter#39;s blocking Espresso work and its purpose is unknown. (flutter/engine#9238) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary. commit 89b1533 Author: jonahwilliams <[email protected]> Date: Mon Jun 10 16:49:44 2019 -0700 skip chunk test commit c11b61f Merge: b182271 1b3fc53 Author: jonahwilliams <[email protected]> Date: Mon Jun 10 16:49:34 2019 -0700 Merge branch 'master' of github.com:flutter/flutter into add_network_image_impl commit b182271 Author: jonahwilliams <[email protected]> Date: Mon Jun 10 16:14:06 2019 -0700 update to remove extra asset image indirection commit 96d7939 Merge: 3700e32 f530b80 Author: jonahwilliams <[email protected]> Date: Mon Jun 10 15:42:02 2019 -0700 Merge branch 'master' of github.com:flutter/flutter into add_network_image_impl commit 3700e32 Author: jonahwilliams <[email protected]> Date: Sat Jun 8 13:13:32 2019 -0700 fix foundation import commit e31b5e4 Author: jonahwilliams <[email protected]> Date: Sat Jun 8 13:09:19 2019 -0700 add web and io implemenations of network and asset image

guojiex and others added 3 commits March 11, 2019 23:11

Merge pull request #1 from flutter/master

e448516

Sync my fork of flutter

Merge branch 'master' of github.com:guojiex/flutter

72e48c6

Add hintStyle in SearchDelegate, so that user can customize hint text…

7cc5020

… color by overriding appBarTheme function in their code. See #19734

googlebot added the cla: yes label Apr 2, 2019

HansMuller added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Apr 2, 2019

rami-a reviewed Apr 26, 2019

View reviewed changes

guojiex added 3 commits April 29, 2019 09:46

Merge branch 'master' of https://github.com/flutter/flutter

f400713

Add search delegate hint text color override unit test.

1eb31e7

reformat search_test.dart

0a8beb0

rami-a reviewed Apr 29, 2019

View reviewed changes

Update formating.

47ada44

rami-a approved these changes Apr 29, 2019

View reviewed changes

rami-a requested a review from HansMuller April 29, 2019 15:17

Add a missing comma

f8d0f6a

rami-a reviewed Apr 29, 2019

View reviewed changes

rami-a suggested changes Apr 29, 2019

View reviewed changes

HansMuller mentioned this pull request May 7, 2019

Search text on showSearch with dark theme is unreadable #32180

Closed

hyperpanthera mentioned this pull request May 12, 2019

use primaryTextTheme instead of textTheme to ensure contrast to AppBar in search #28165

Closed

9 tasks

mikuhl-dev mentioned this pull request Jun 8, 2019

Allow search page widget search field hint text and keyboard text input action to be customizable #28807

Closed

10 tasks

rami-a approved these changes Jun 11, 2019

View reviewed changes

justinmc merged commit 1bc8402 into flutter:master Jun 11, 2019

justinmc mentioned this pull request Jun 11, 2019

SearchDelegate should respect InputDecoration theme override #19734

Closed

neokree mentioned this pull request Feb 7, 2020

How to set the cursor color in SearchDelegate #48857

Closed

github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021

Add hintStyle in SearchDelegate #30388

Add hintStyle in SearchDelegate #30388

Uh oh!

Conversation

guojiex commented Apr 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Checklist

Breaking Change

Uh oh!

guojiex commented Apr 4, 2019

Uh oh!

rami-a left a comment

Choose a reason for hiding this comment

Uh oh!

guojiex commented Apr 29, 2019

Uh oh!

rami-a left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rami-a Apr 29, 2019

Choose a reason for hiding this comment

Uh oh!

guojiex Apr 29, 2019

Choose a reason for hiding this comment

Uh oh!

rami-a left a comment

Choose a reason for hiding this comment

Uh oh!

rami-a Apr 29, 2019 • edited by HansMuller Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

guojiex May 3, 2019

Choose a reason for hiding this comment

Uh oh!

NBTX May 31, 2019

Choose a reason for hiding this comment

Uh oh!

justinmc Jun 10, 2019

Choose a reason for hiding this comment

Uh oh!

rami-a Jun 11, 2019

Choose a reason for hiding this comment

Uh oh!

rami-a left a comment

Choose a reason for hiding this comment

Uh oh!

guojiex commented Apr 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guojiex commented Apr 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mdusafp commented May 11, 2019

Uh oh!

hyperpanthera commented May 12, 2019

Uh oh!

mikuhl-dev commented Jun 8, 2019

Uh oh!

hyperpanthera commented Jun 8, 2019

Uh oh!

mikuhl-dev commented Jun 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mikuhl-dev commented Jun 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

guojiex commented Apr 2, 2019 •

edited

Loading

rami-a Apr 29, 2019 •

edited by HansMuller

Loading

guojiex commented Apr 29, 2019 •

edited

Loading

guojiex commented Apr 30, 2019 •

edited

Loading

mikuhl-dev commented Jun 8, 2019 •

edited

Loading