Skip to content

Support "flutter refresh" in the Gradle-based sample project - #3034

Merged
jason-simmons merged 1 commit into
flutter:masterfrom
jason-simmons:gradle_flx_refresh
Apr 1, 2016
Merged

jason-simmons merged 1 commit into
flutter:masterfrom
jason-simmons:gradle_flx_refresh

Conversation

@jason-simmons

Copy link
Copy Markdown
Contributor

After deploying and launching the APK, the app's Dart code can be updated with:

  • cd app/src/flutter
  • flutter refresh --activity=com.example.flutter/.ExampleActivity

@jason-simmons

Copy link
Copy Markdown
Contributor Author

@eseidelGoogle @yjbanov

@yjbanov

yjbanov commented Mar 31, 2016

Copy link
Copy Markdown
Contributor

LGTM!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt we want this ability in production code. Unclear if this should use ACTION_RUN or not:
http://developer.android.com/reference/android/content/Intent.html#ACTION_RUN

Seems like any other process on the phone could hijack the permissions of this app this way. @abarth

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment about that issue?

After deploying and launching the APK, the app's Dart code can be updated with:
  * cd app/src/flutter
  * flutter refresh --activity=com.example.flutter/.ExampleActivity
@jason-simmons

Copy link
Copy Markdown
Contributor Author

Made refresh support conditional on the application's debuggable flag.
Refresh will be disabled in release builds of an APK.

@abarth

abarth commented Apr 1, 2016

Copy link
Copy Markdown
Contributor

Nice. LGTM

@jason-simmons
jason-simmons merged commit 379c563 into flutter:master Apr 1, 2016
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants