Skip to content

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Mar 29, 2019

Description

To make it clear which features are still experimental, these should be disabled for users on "stable" branches.

Related Issues

Fixes #30152

Tests

I added the following tests:

  • flutter_command_test.dart: Experimental command can be disabled on stable branch.
  • flutter_command_test.dart: Experimental command Works normally on regular branches

These verify that executing an experimental command on a stable branch throws a tool exit.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@jonahwilliams jonahwilliams marked this pull request as ready for review March 29, 2019 05:50
@eseidelGoogle
Copy link
Contributor

Thank you @jonahwilliams. FYI @timsneath @kevmoo

@jonahwilliams jonahwilliams requested a review from zanderso March 29, 2019 16:33
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@goderbauer goderbauer added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 30, 2019
@jonahwilliams jonahwilliams merged commit 99b4459 into flutter:master Apr 8, 2019
@jonahwilliams jonahwilliams deleted the experimental_features branch April 8, 2019 20:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add configuration to disable certain tool features on stable branches

5 participants