Reland composite physical layers for all platforms #29701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
added
framework
Contributor
|
I believe this is the culprit for the flutter_gallery_io32__transition perf flakiness |
Contributor
Author
|
For the 90th percentile rasterizer benchmark? Quite possibly - I rebaslined two others, may have to rebaseline that one too. |
Contributor
|
flutter_gallery_io32__transition doesn't seem to be so flaky to me. I see that there has been a regression starting from #29377 , which I think might be caused by flutter/engine#8157 If @dnfield can confirm that the regression is caused by flutter/engine#8157, then we shall certainly just rebaseline the benchmark since the AA shapes are the correct behavior. |
Contributor
Author
|
I rebaselined the benchmark. AA definitely caused some regressions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #27891
Relands the revert of #29532
We've gotten sign off from the Fuchsia team to not special case elevation == 0. With this reland, we will now properly clip in a RenderFlex even if a material widget with elevation 0 overflows it. This also contains a test to make sure we don't regress that.
/cc @liyuqian @goderbauer @mklim