Skip to content

Roll engine 96ad0c8926b0..a1dcb2ea987e (6 commits) #29658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
engine-flutter-autoroll merged 6 commits into from
Mar 20, 2019
Merged

Roll engine 96ad0c8926b0..a1dcb2ea987e (6 commits) #29658

engine-flutter-autoroll merged 6 commits into from
Mar 20, 2019

Conversation

@engine-flutter-autoroll
Copy link
Contributor

@engine-flutter-autoroll engine-flutter-autoroll commented Mar 20, 2019

flutter/engine@96ad0c8...a1dcb2e

git log 96ad0c8..a1dcb2e --no-merges --oneline
a1dcb2e [ios] Set contentsScale before we commit CATransaction (flutter/engine#8218)
fa1931f Send macOS keyboard data to the engine (flutter/engine#8219)
45f69ac Plumb a reference of PlatformViewsController and AccessibilityBridge to each other (flutter/engine#8208)
7cbbdb4 libtxt: more accurate tracking of run positioning and width for justified text (flutter/engine#8214)
1728103 Add a build dependencies script for Linux desktop (flutter/engine#8160)
d764b69 Add docs for helpful commands to fix format (flutter/engine#8171)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.

@engine-flutter-autoroll
Copy link
Contributor Author

engine-flutter-autoroll commented Mar 20, 2019

Auto-roller completed checks. About to merge.

@engine-flutter-autoroll engine-flutter-autoroll merged commit 9596657 into flutter:master Mar 20, 2019
@jonahwilliams
Copy link
Contributor

jonahwilliams commented Mar 20, 2019

Several device lab tests are failing now:

stdout: 
stdout: io.flutter.demo.gallery.FlutterGalleryInstrumentationTest > activityLoaded[Moto G (4) - 7.0] �[31mFAILED �[0m
stdout: 	java.lang.NullPointerException: Attempt to invoke virtual method 'io.flutter.app.FlutterPluginRegistry io.flutter.view.FlutterNativeView.getPluginRegistry()' on a null object reference
stdout: 	at io.flutter.view.FlutterView.getPluginRegistry(FlutterView.java:219)
stdout: 11:31:13 V/InstrumentationResultParser: INSTRUMENTATION_STATUS_CODE: -2

amirh added a commit to amirh/flutter that referenced this pull request Mar 20, 2019
@amirh
Revert last 2 engine rolls.
de48911 
Reverting to the engine version prior to:
flutter#29658
@amirh amirh mentioned this pull request Mar 20, 2019
Merged
amirh added a commit that referenced this pull request Mar 20, 2019
@amirh
Revert last 2 engine rolls. (#29684)
8da0721 
Reverting to the engine version prior to:
#29658
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@engine-flutter-autoroll @jonahwilliams @googlebot