Skip to content

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Mar 19, 2019

Reverts #29532

We need to sort out when we have to mark these layers as requiring compositing - Fuchsia currently wants them only composited if the elevation is 0, but that breaks things in iOS and Android.

#27891

/cc @yjbanov @goderbauer

@dnfield dnfield added the framework flutter/packages/flutter repository. See also f: labels. label Mar 19, 2019
@dnfield dnfield requested a review from yjbanov March 19, 2019 20:04
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dnfield dnfield merged commit 5764aee into master Mar 19, 2019
@dnfield dnfield deleted the revert-29532-composite_elevations branch March 19, 2019 22:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants