Reland composite physical layers on all platforms #29532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
added
customer: fuchsia
framework
Contributor
|
I recommend making a test case where it's harder to mistake the change for a positive change. For example, maybe a test where the test itself verifies that the antialiasing is happening (not a golden file test, but one where the image is actually examined by the code to verify that there's more than two colours on the boundary or some such). |
Contributor
Author
|
I think our migration to Skia gold should help this - we'll have a better UI for evaluating golden changes and seeing exactly what has changed without manual steps involved in generating a new image. Are you suggesting that matches golden shoul dhave this logic though? It should be able to detect anti-aliasing regressions? |
dnfield
added a commit
that referenced
this pull request
Mar 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This relands #28919, which had to be reverted because the engine side was misisng anti-aliasing bits on the paint for physical layer drawing on non-Fuchsia platforms. That was fixed in flutter/engine#8157 and has since rolled through to the framework.
This PR also undoes some of the golden changes from the original PR, where I mistakenly believed there were subtle acceptable differences - I completely missed that I was turning off anti-aliasing (which was caught later in the google3 roll).
As noted on the original PR, this is expected to improve frame build times, but make "rasterization" time in the engine worse (we're shifting work from the framework to the engine).
/cc @HansMuller @jason-simmons @willlarche @liyuqian @goderbauer @mklim who were involved in the original landing and/or rolling back of this.
Related Issues
Fixes #27891
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?