Skip to content

Conversation

@GaryQian
Copy link
Contributor

Reverts #29323

Mac tests are failing.

Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaryQian GaryQian changed the title Revert "Roll engine 31b289f277c6..b1b388f1c235 (7 commits)" Revert "Roll engine 31b289f277c6..b1b388f1c235 (7 commits)", Roll to 8b1a299ed instead. Mar 14, 2019
@jonahwilliams
Copy link
Contributor

@GaryQian its okay to land a revert can be landed without waiting for green

@GaryQian
Copy link
Contributor Author

This isn't a clean revert, I combined this with a roll to 8b1a299.

@GaryQian GaryQian merged commit eb294a9 into master Mar 14, 2019
@dnfield dnfield deleted the revert-29323-roll_branch branch May 15, 2019 16:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants