A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

See #27205 for confirming CLA.

The bug that was causing the image comparison tests to fail was that my new layout algorithm was adding a subtext gap below the subtext when the old one wasn't. My fix is to remove that extra subtext gap.

So originally and after my fix, the parent container ends immediately after any subtext with no spacing (see screenshot below). I think this is best because there is also no spacing when there is no subtext at all. Any desired spacing will be up to the user.

The same thing with spacing after the subtext looked like this. This is no longer the behavior with my fix.

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

Another bug for other image comparison tests was related to errorText positioning. My new layout algorithm ignored it if it was an empty string, but for legacy reasons needed to support it. The bug ended up causing an input that wasn't as tall as it used to be and slightly out of place:

I also didn't lay it out when I should have in a few other cases, which was fixed with the above.

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@HansMuller This is ready for review. You've already reviewed this PR when it went in the first time, but now I've added five new commits, starting with f276609. The new things that I've done are:

1. Fixed and tested a subtext bug explained in a comment above, exposed by adwords mobile app tests.
2. Fixed and tested an errorText bug explained in another comment above, also exposed by adwords mobile app tests.
3. Added minlines and expands to TextFormField and CupertinoTextField, just because I noticed that I forgot to do so in the original PR.