Skip to content

Revert "Fix TextField height issues" #29093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tvolkert merged 1 commit into from
Mar 9, 2019
Merged

Revert "Fix TextField height issues" #29093

tvolkert merged 1 commit into from
Mar 9, 2019

Conversation

@tvolkert
Copy link
Contributor

@tvolkert tvolkert commented Mar 9, 2019

Reverts #27205

dnfield
dnfield approved these changes Mar 9, 2019
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvolkert tvolkert merged commit f21497e into master Mar 9, 2019
@tvolkert tvolkert deleted the revert-27205-text-field-height branch March 9, 2019 09:18
@dnfield
Copy link
Contributor

dnfield commented Mar 9, 2019

/cc @justinmc fyi - this broke some internal tests

@tvolkert
Copy link
Contributor Author

tvolkert commented Mar 9, 2019

Yep - specifically, see this

@justinmc justinmc mentioned this pull request Mar 12, 2019
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tvolkert @dnfield @googlebot