Remove timeout from add2app test for iOS #28746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
added
a: tests
Contributor
Author
|
Upstream change has landed, will just need to get it rolled into framework |
Contributor
Author
|
Once #28688 lands this can be rebased and should work. |
xster
reviewed
Mar 18, 2019
|
|
||
| NS_ASSUME_NONNULL_BEGIN | ||
|
|
||
| @interface DualFlutterViewController : UIViewController |
Member
There was a problem hiding this comment.
Semi unrelated but just for easier maintenance in the future
Can you, from README.md, call out the related filenames of the tests for each entry so we can associate which test is done in which file?
| [[NSNotificationCenter defaultCenter] removeObserver:observer]; | ||
| }]; | ||
| [viewController.engine ensureSemanticsEnabled]; | ||
| while (semanticsAvailable == NO && tries != 0) { |
Member
There was a problem hiding this comment.
Add one line saying what is synchronous and what isn't in a comment here and in the ensureSemanticsEnabled objective-c doc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the flake in ios_add2app and removes the timeout. We still have retry logic in here - eventually, EarlGrey will be able to do this without us needing this logic.
This PR will fail until the related engine PR lands in the framework.
Related Issues
flutter/engine#8005
#24519 (related, but for something slightly different).
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?