Skip to content

Reland "Shader warm up (#27660)" #28537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liyuqian merged 3 commits into from
Feb 27, 2019
Merged

Reland "Shader warm up (#27660)" #28537

liyuqian merged 3 commits into from
Feb 27, 2019

Conversation

@liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Feb 26, 2019

This reverts commit adc8e15.

This should be safe to land once #28530 gets merged

jonahwilliams
jonahwilliams reviewed Feb 26, 2019
View reviewed changes
packages/flutter/lib/src/painting/shader_warm_up.dart Outdated
@@ -0,0 +1,148 @@
// Copyright 2015 The Chromium Authors. All rights reserved.
Copy link
Contributor

@jonahwilliams jonahwilliams Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be 2019?

Copy link
Contributor Author

@liyuqian liyuqian Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

jonahwilliams
jonahwilliams reviewed Feb 27, 2019
View reviewed changes
examples/layers/test/smoketests/raw/shader_warm_up_test.dart Outdated
@@ -0,0 +1,13 @@
// Copyright 2017 The Chromium Authors. All rights reserved.
Copy link
Contributor

@jonahwilliams jonahwilliams Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright 2017 The Chromium Authors. All rights reserved.
// Copyright 2019 The Chromium Authors. All rights reserved.

Copy link
Contributor Author

@liyuqian liyuqian Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

jonahwilliams
jonahwilliams reviewed Feb 27, 2019
View reviewed changes
examples/layers/raw/shader_warm_up.dart Outdated
@@ -0,0 +1,33 @@
// Copyright 2015 The Chromium Authors. All rights reserved.
Copy link
Contributor

@jonahwilliams jonahwilliams Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright 2015 The Chromium Authors. All rights reserved.
// Copyright 2019 The Chromium Authors. All rights reserved.

Copy link
Contributor Author

@liyuqian liyuqian Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

jonahwilliams
jonahwilliams reviewed Feb 27, 2019
View reviewed changes
dev/devicelab/bin/tasks/cubic_bezier_perf__timeline_summary.dart Outdated
@@ -0,0 +1,14 @@
// Copyright 2018 The Chromium Authors. All rights reserved.
Copy link
Contributor

@jonahwilliams jonahwilliams Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright 2018 The Chromium Authors. All rights reserved.
// Copyright 2019 The Chromium Authors. All rights reserved.

Copy link
Contributor Author

@liyuqian liyuqian Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

jonahwilliams
jonahwilliams reviewed Feb 27, 2019
View reviewed changes
dev/benchmarks/macrobenchmarks/test_driver/util.dart Outdated
@@ -0,0 +1,44 @@
// Copyright 2015 The Chromium Authors. All rights reserved.
Copy link
Contributor

@jonahwilliams jonahwilliams Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright 2015 The Chromium Authors. All rights reserved.
// Copyright 2019 The Chromium Authors. All rights reserved.

Copy link
Contributor Author

@liyuqian liyuqian Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

jonahwilliams
jonahwilliams reviewed Feb 27, 2019
View reviewed changes
dev/benchmarks/macrobenchmarks/test_driver/cubic_bezier_perf_test.dart Outdated
@@ -0,0 +1,11 @@
// Copyright 2018 The Chromium Authors. All rights reserved.
Copy link
Contributor

@jonahwilliams jonahwilliams Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright 2018 The Chromium Authors. All rights reserved.
// Copyright 2019 The Chromium Authors. All rights reserved.

Copy link
Contributor Author

@liyuqian liyuqian Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

jonahwilliams
jonahwilliams reviewed Feb 27, 2019
View reviewed changes
dev/benchmarks/macrobenchmarks/test_driver/cubic_bezier_perf.dart Outdated
@@ -0,0 +1,40 @@
// Copyright 2018 The Chromium Authors. All rights reserved.
Copy link
Contributor

@jonahwilliams jonahwilliams Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright 2018 The Chromium Authors. All rights reserved.
// Copyright 2019 The Chromium Authors. All rights reserved.

Copy link
Contributor Author

@liyuqian liyuqian Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

jonahwilliams
jonahwilliams reviewed Feb 27, 2019
View reviewed changes
dev/benchmarks/macrobenchmarks/lib/src/cubic_bezier.dart Outdated
@@ -0,0 +1,380 @@
// Copyright 2015 The Chromium Authors. All rights reserved.
Copy link
Contributor

@jonahwilliams jonahwilliams Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright 2015 The Chromium Authors. All rights reserved.
// Copyright 2019 The Chromium Authors. All rights reserved.

Copy link
Contributor Author

@liyuqian liyuqian Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

liyuqian
liyuqian commented Feb 27, 2019
View reviewed changes
Copy link
Contributor Author

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! Sorry that I forget to check other files...

dev/benchmarks/macrobenchmarks/lib/src/cubic_bezier.dart Outdated
@@ -0,0 +1,380 @@
// Copyright 2015 The Chromium Authors. All rights reserved.
Copy link
Contributor Author

@liyuqian liyuqian Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

dev/benchmarks/macrobenchmarks/test_driver/cubic_bezier_perf.dart Outdated
@@ -0,0 +1,40 @@
// Copyright 2018 The Chromium Authors. All rights reserved.
Copy link
Contributor Author

@liyuqian liyuqian Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

dev/benchmarks/macrobenchmarks/test_driver/cubic_bezier_perf_test.dart Outdated
@@ -0,0 +1,11 @@
// Copyright 2018 The Chromium Authors. All rights reserved.
Copy link
Contributor Author

@liyuqian liyuqian Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

dev/benchmarks/macrobenchmarks/test_driver/util.dart Outdated
@@ -0,0 +1,44 @@
// Copyright 2015 The Chromium Authors. All rights reserved.
Copy link
Contributor Author

@liyuqian liyuqian Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

dev/devicelab/bin/tasks/cubic_bezier_perf__timeline_summary.dart Outdated
@@ -0,0 +1,14 @@
// Copyright 2018 The Chromium Authors. All rights reserved.
Copy link
Contributor Author

@liyuqian liyuqian Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

examples/layers/raw/shader_warm_up.dart Outdated
@@ -0,0 +1,33 @@
// Copyright 2015 The Chromium Authors. All rights reserved.
Copy link
Contributor Author

@liyuqian liyuqian Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

examples/layers/test/smoketests/raw/shader_warm_up_test.dart Outdated
@@ -0,0 +1,13 @@
// Copyright 2017 The Chromium Authors. All rights reserved.
Copy link
Contributor Author

@liyuqian liyuqian Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

jonahwilliams
jonahwilliams approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoechi zoechi added framework flutter/packages/flutter repository. See also f: labels. c: performance Relates to speed or footprint issues (see "perf:" labels) labels Feb 27, 2019
@liyuqian liyuqian merged commit 19a6a6f into flutter:master Feb 27, 2019
@HansMuller HansMuller mentioned this pull request Apr 2, 2019
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xster xster Awaiting requested review from xster

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: performance Relates to speed or footprint issues (see "perf:" labels) framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liyuqian @jonahwilliams @zoechi @googlebot