Skip to content

Fix type issue of the timelineEvents assignment #28530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liyuqian merged 1 commit into from
Feb 27, 2019
Merged

Fix type issue of the timelineEvents assignment #28530

liyuqian merged 1 commit into from
Feb 27, 2019

Conversation

@liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Feb 26, 2019 •
edited
Loading

This fixes #28374

The fact that json_rpc_2 is hiding exceptions like this might be a bigger issue: #28531

This will allow #27660 to reland to fix several very high priority performance issues.

@liyuqian liyuqian requested a review from Hixie February 26, 2019 22:02
@liyuqian liyuqian mentioned this pull request Feb 26, 2019
Closed
@liyuqian
Fix type issue of the timelineEvents assignment
e7ba4a7 
This fixes flutter#28374

The fact that json_rpc_2 is hiding exceptions like this might be a
bigger issue: flutter#28531
@liyuqian liyuqian force-pushed the fix_timeline_stream branch from 5e7e2f5 to e7ba4a7 Compare February 26, 2019 22:10
jonahwilliams
jonahwilliams approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liyuqian liyuqian mentioned this pull request Feb 26, 2019
Merged
@liyuqian liyuqian merged commit 8e6f468 into flutter:master Feb 27, 2019
liyuqian added a commit that referenced this pull request Feb 27, 2019
@liyuqian
Reland "Shader warm up (#27660)" (#28537)
19a6a6f 
This reverts commit adc8e15.

This should be safe to land once #28530 gets merged

Merge on yellow doc test because the doc test is actually green.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Hixie Hixie Awaiting requested review from Hixie

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

start_up tests in our post-submit bots seem to become flaky

3 participants

@liyuqian @jonahwilliams @googlebot