Reland "Allow for gradle downloading missing SDK assets" (#28097) #28355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
And since the title doesn't acutally link it, related to #28097 |
tvolkert
approved these changes
Feb 22, 2019
Contributor
Author
|
Acutally I had to fix the Android SDK layout anyway for Windows to make this work, and it turns out it wasn't as involved as I thought (just need exe/bat names appended, directory layouts are the same). |
dnfield
added
platform-android
dotdoom
added a commit
to dotdoom/fastlane-plugin-flutter
that referenced
this pull request
Mar 24, 2019
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25119
Fixes #28076
Relevant changes compared with the original PR are in 6c0e3d9
This could have been caught in unit tests. I'm not adding a new test as part of this PR because that's a bigger effort - right now all of our Android SDK tests assume a non-Windows FS layout. Opened #28354 to track that effort.